Update PropTypes to support single axis scale values #2537
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #2489
Users would get PropType errors on
scale
props when single axis values were provided (e.g.scale={{ x: 'log' }}
) even though documentation and demos both have examples of single axis scale props and the components functioned normally.PropTypes for
scale
have been updated to no longer require both axises.PropTypes.shape
was replaced withPropTypes.exact
in order to catch invalid properties (e.g.{ z: 'log' }
)Caveat
TypeScript error is suppressed on updated prop types. The error appears when
isRequired
is removed from either axis properties. A verbose workaround could be to list each possible combination of axis properties to keepisRequired
like so: