Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors when using 'Victory' with React@16 #724

Closed
mzygmunt opened this issue Aug 22, 2017 · 2 comments · Fixed by FormidableLabs/victory-core#295
Closed

Errors when using 'Victory' with React@16 #724

mzygmunt opened this issue Aug 22, 2017 · 2 comments · Fixed by FormidableLabs/victory-core#295

Comments

@mzygmunt
Copy link

Hello,
I noticed following errors when I updated my React to version 16 (beta):
image
@ajosephjohnson
Copy link

I also received these errors:

VictoryAxis.componentWillMount(): Assigning directly to this.state is deprecated (except inside a component's constructor). Use setState instead.

@boygirl
Copy link
Contributor

boygirl commented Sep 6, 2017

@mzygmunt @ajosephjohnson Thanks for pointing this out. I'll get a fix out in the next version

@mathisonian mathisonian mentioned this issue Sep 7, 2017
Closed
This was referenced Sep 8, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

guard against missing state object FormidableLabs/victory-core
3 participants
@boygirl @ajosephjohnson @mzygmunt