Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to remove strokeWidth from Candles in Candlestick? #886

Closed
5 tasks done
boygirl opened this issue Jan 1, 2018 · 3 comments
Closed
5 tasks done

How to remove strokeWidth from Candles in Candlestick? #886

boygirl opened this issue Jan 1, 2018 · 3 comments
Assignees
Labels
Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release

Comments

@boygirl
Copy link
Contributor

boygirl commented Jan 1, 2018

From @kesha-antonov on December 25, 2017 19:42

Bugs and Questions

Checklist

  • This is a victory-native specific issue. (Issues that also appear in victory should be opened here)

  • I have read through the FAQ and Guides before asking a question

  • I am using the latest version of victory-native

  • I have checked to make sure that my versions of react-native and react-native-svg are compatible with this version of victory-native. Read about version requirements

  • I've searched open issues to make sure I'm not opening a duplicate issue

The Problem

I'm trying to remove borders of Candles in Candlestick. If I set style={{data:{strokeWidth: 0}}} then Wicks will disappeared. So I see that strokeWidth apply to Candle and Wicks in the same time. Can you separate them in different props please?

Reproduction

  1. Open https://formidable.com/open-source/victory/docs/victory-candlestick/#style
  2. Set strokeWidth=0

Before:

screen shot 2017-12-25 at 22 41 48

After:

screen shot 2017-12-25 at 22 41 53

Copied from original issue: FormidableLabs/victory-native#224

@boygirl
Copy link
Contributor Author

boygirl commented Jan 1, 2018

@kesha-antonov I am going to move this issue to the main victory library and label it as a feature request

@boygirl boygirl added Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release improvement labels Jan 1, 2018
@kesha-antonov
Copy link

Thanks!

@boygirl
Copy link
Contributor Author

boygirl commented Jan 16, 2018

Changes:

  • Render the wick in two line segments so that it never appears to go through the box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release
Projects
None yet
Development

No branches or pull requests

3 participants