You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that icon rendering was a off for me, and it was especially noticable on the info icon, which looks like this for me right now:
Turns out that the library treats all SVG attributes as camelCase. This is fine for React because it translates those attributes to kebab-case, but Preact doesn't do this.
I could work around it by using preact-compat, but in that case I might as well also use react-feather instead, and I really want to try to keep it Preact-only and avoid any unnecessary dependencies.
I'm willing to open a PR to update all the attributes if you want. 🙂
The text was updated successfully, but these errors were encountered:
Hi! 👋 First off: thanks for this library!
I noticed that icon rendering was a off for me, and it was especially noticable on the info icon, which looks like this for me right now:
Turns out that the library treats all SVG attributes as camelCase. This is fine for React because it translates those attributes to kebab-case, but Preact doesn't do this.
I could work around it by using
preact-compat
, but in that case I might as well also usereact-feather
instead, and I really want to try to keep it Preact-only and avoid any unnecessary dependencies.I'm willing to open a PR to update all the attributes if you want. 🙂
The text was updated successfully, but these errors were encountered: