Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG attributes are broken #1

Closed
koenkivits opened this issue Mar 14, 2018 · 2 comments · Fixed by #2
Closed

SVG attributes are broken #1

koenkivits opened this issue Mar 14, 2018 · 2 comments · Fixed by #2

Comments

@koenkivits
Copy link
Contributor

koenkivits commented Mar 14, 2018

Hi! 👋 First off: thanks for this library!

I noticed that icon rendering was a off for me, and it was especially noticable on the info icon, which looks like this for me right now:

screenshot from 2018-03-14 20-03-11

Turns out that the library treats all SVG attributes as camelCase. This is fine for React because it translates those attributes to kebab-case, but Preact doesn't do this.

I could work around it by using preact-compat, but in that case I might as well also use react-feather instead, and I really want to try to keep it Preact-only and avoid any unnecessary dependencies.

I'm willing to open a PR to update all the attributes if you want. 🙂

@ForsakenHarmony
Copy link
Owner

sure I'd be open for a PR, you'll want to check out submodules and modify the build script in bin/build.js though

@koenkivits
Copy link
Contributor Author

Thanks for the pointers! I'll have a look tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants