Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type 'IconDefinition' is not assignable to type 'IconProp' #470

Closed
ChristopherMeek opened this issue Feb 8, 2022 · 7 comments
Closed

Type 'IconDefinition' is not assignable to type 'IconProp' #470

ChristopherMeek opened this issue Feb 8, 2022 · 7 comments

Comments

@ChristopherMeek
Copy link

This seems to be a duplicate of #462, but I've just updated everything in my project to v6

Versions
"@fortawesome/free-brands-svg-icons": "^6.0.0",
"@fortawesome/free-regular-svg-icons": "^6.0.0",
"@fortawesome/pro-duotone-svg-icons": "^6.0.0",
"@fortawesome/pro-light-svg-icons": "^6.0.0",
"@fortawesome/pro-solid-svg-icons": "^6.0.0",
"@fortawesome/react-fontawesome": "^0.1.17",

The following example given me the error. Is this just a case of the @fortawesome/react-fontawesome package, totally understandably, lagging a few hours behind the 6.0 release of everything else?

import { faSave } from "@fortawesome/pro-light-svg-icons"

function Component() {
  <FontAwesomeIcon icon={faSave} />
}
@ChristopherMeek
Copy link
Author

Update, manually adding @fortawesome/fontawesome-svg-core seemse to fix the problem. It brings in v1.3 and I think the react-fontawesome library only brings in 1.2.32. So i'm guessing this will be fixed when react-fontawesome is updated for the v6 icons libraries

@duhaime
Copy link

duhaime commented Feb 8, 2022

I needed to replace all my versions with "latest" to please typescript:

    "@fortawesome/free-brands-svg-icons": "latest",
    "@fortawesome/free-regular-svg-icons": "latest",
    "@fortawesome/free-solid-svg-icons": "latest",
    "@fortawesome/fontawesome-svg-core": "latest",
    "@fortawesome/react-fontawesome": "latest",

@victorsmits
Copy link

Same issue with latest version

@robmadole
Copy link
Member

Can you all try upgrading to 6.1.1? I think we've got this fixed.

@TiTnOuK
Copy link

TiTnOuK commented Apr 14, 2022

I confirm that version 6.1.1 fixes the problem.
Thanks!

@acelaya
Copy link

acelaya commented Sep 24, 2022

This issue seems to be back with v6.2.0

@robmadole
Copy link
Member

@acelaya I can't reproduce this. Can you provide one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants