Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable text on some UI elements when using dynamic theme #41

Open
6 tasks done
min7-i opened this issue Jan 7, 2024 · 5 comments
Open
6 tasks done

Unreadable text on some UI elements when using dynamic theme #41

min7-i opened this issue Jan 7, 2024 · 5 comments
Labels
bug Something is not working

Comments

@min7-i
Copy link
Contributor

min7-i commented Jan 7, 2024

Checklist

  • I can reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Describe the bug
The attendee suggestion list is hard to read when using the material you colors in a light theme. Additionally, in light themes without material you colors the suggestion list uses a black background with white text.

To Reproduce
Steps to reproduce the behavior:

  1. Make sure the app has the permission to access contacts.
  2. Use the material you colors with Android set to light mode.
  3. Create a new CalDAV event.
  4. Go to the attendee field.
  5. Start typing the name of one of your contacts.
  6. The contact suggestion list is shown.

Expected behavior
For light themes the suggestion list uses a light background with a font color that provides enough contrast. I'd suggest to simply use a white background and a black font.

Screenshots

material you light light theme material you dark
calendar attendees dropdown_material you light (2) calendar attendees dropdown_light calendar attendees dropdown_material you dark (2)

Device info (please complete the following information):

  • Model: Google Pixel 6a
  • OS: Android 14 (GrapheneOS)
  • Version: 1.0.2

Additional context
N/A

@min7-i min7-i added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Jan 7, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Jan 7, 2024
@schneidr
Copy link

schneidr commented Jan 8, 2024

I was about to post the same issue for the widget settings ... is it related enough to be handled in this issue or do you want a separate one for it?

Sample screenshot:

@Aga-C
Copy link
Member

Aga-C commented Jan 8, 2024

@schneidr It's related, no need for a new issue.

@min7-i
Copy link
Contributor Author

min7-i commented Jan 8, 2024

I was about to post the same issue for the widget settings ...

I guess for the event list widget the areas marked in red are affected:
calendar widget event list_material you light theme_github

left part: dialog shown when tapping on the button "Within the next year"
right part: second dialog shown when selecting the custom option from the first dialog

@schneidr
Copy link

schneidr commented Jan 9, 2024

I was about to post the same issue for the widget settings ...

I guess for the event list widget the areas marked in red are affected:

Correct for the screenshot on the left. The widget itself is working properly for me after setting useful colors.

@naveensingh naveensingh changed the title Attendee suggestion list is hard to read when using material you colors in light theme Unreadable text on some UI elements when using dynamic theme Jan 11, 2024
@SpaceFrrog
Copy link

I have some related enhancements to the Dynamic Color Theme. I've noticed that the colors are much brighter than specified in the Material Design Guidelines. For example, the background color of the FAB is A1-400 in dark mode, but according to the Material Guidelines it should be A1-700. I think it would be more visually pleasing if the Material Design Guidelines were adhered to, also for all other components!

Guidelines:
https://m3.material.io/components
https://m3.material.io/theme-builder#/dynamic
Calendar_Colors
Color_Chips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

4 participants