Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompressing ZIP file results in error and 0 bit file #87

Open
7 tasks done
nehemiagurl opened this issue Apr 21, 2024 · 7 comments
Open
7 tasks done

Decompressing ZIP file results in error and 0 bit file #87

nehemiagurl opened this issue Apr 21, 2024 · 7 comments
Assignees
Labels
bug Something is not working

Comments

@nehemiagurl
Copy link

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.0.1

Affected Android/Custom ROM version

Android 12

Affected device model

Galaxy A12

How did you install the app?

Google Play Store

Steps to reproduce the bug

  1. Go to the ZIP file location (any).
  2. Click on the ZIP file to open, then on the "decompress" button in the top right corner.
  3. Select a folder to decompress to (any).

Expected behavior

Folder decompresses normally, resulting in file(s) in a "decompress" folder within the destination folder.

Actual behavior

An error message pops up:
Screenshot_20240421-085717_File Manager
While a "decompress" folder is created, the file in it is 0-bit:
Screenshot_20240421-090205_File Manager

Screenshots/Screen recordings

(see above)

Additional information

If needed, I can send the ZIP file over for reproduction.

@nehemiagurl nehemiagurl added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Apr 21, 2024
@nehemiagurl
Copy link
Author

nehemiagurl commented Apr 21, 2024

it actually seems like Fossify File Manager is reading the ZIP file incorrectly in the prepatory stage: compare these two screenshots from Fossify and from Samsung File Manager.
Screenshot_20240421-091544_File Manager
Screenshot_20240421-091601_My Files

@Aga-C
Copy link
Member

Aga-C commented Apr 21, 2024

Can you send a sample file? I just tested various ZIP files, and unpacking works correctly.

@Aga-C Aga-C added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Apr 21, 2024
@nehemiagurl
Copy link
Author

I can reproduce only with two specific ZIP files neither of which are meant for general distribution. Do you have access to the hello@Fossify.org email address? I can send them there.

@github-actions github-actions bot removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Apr 21, 2024
@Aga-C
Copy link
Member

Aga-C commented Apr 21, 2024

Please send it there, we will check it.

@nehemiagurl
Copy link
Author

sent with password FossifyOrg.

@Aga-C
Copy link
Member

Aga-C commented Apr 21, 2024

Thanks for sending! I've confirmed, and in fact that ZIP doesn't work in File Manager. 

From a quick search, it looks like we've inherited that bug from zip4j library: srikanth-lingala/zip4j#135.

@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Apr 21, 2024
@MonikaBarget
Copy link

Interestingly, unzipping .zip downloads from Amazon Music worked for me when I first got the app, but unzipping my own .zip folders or those created by colleagues does not work at all. One of the reasons why I got the Fossify app for my Fairphone was that I was hoping it would handle ZIP. Is there any recommendation on what other apps to install while ZIP isn't working in the File Manager?

@naveensingh naveensingh self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

4 participants