Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gujarati language layout #22

Open
Abcd1234-dot opened this issue Jan 21, 2024 · 6 comments · May be fixed by #27
Open

Add Gujarati language layout #22

Abcd1234-dot opened this issue Jan 21, 2024 · 6 comments · May be fixed by #27
Labels
feature request Issue is about a new feature in the app

Comments

@Abcd1234-dot
Copy link

Checklist

    • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
    • I have read the FAQ and my problem isn't listed.
    • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
    • This issue contains only one feature request.

Is your feature request related to a problem? Please describe.
There's currently no Gujarati language layout in app.

Describe the solution you'd like
I have created a pull request to florisboard to add gujarati layout, created issue to openboard (fork by helium314) to add the layout. I am not sure how I can contribute to fossify keyboard as there's no guide available on here for adding new layouts. But this is the following json file I created which I also submitted to openboard. Please have a look. I am not a developer so there could be syntax error.
Gujarati_layout(final).json

Describe alternatives you've considered

Additional context

@Abcd1234-dot Abcd1234-dot added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 21, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Jan 21, 2024
@Aga-C
Copy link
Member

Aga-C commented Jan 21, 2024

Take a look at https://github.com/FossifyOrg/Keyboard/pull/4/files, and do similarly with your language.

@Abcd1234-dot
Copy link
Author

Abcd1234-dot commented Jan 21, 2024

Alright, I understood basic things. But how to use shift key on-off layouts? there many characters to fit in, and there's no "capital" or "small" letters, so we can use shift key off for page 1 and on for page 2 I guess?

@ronniedroid
Copy link
Contributor

Alright, I understood basic things. But how to use shift key on-off layouts? there many characters to fit in, and there's no "capital" or "small" letters, so we can use shift key off for page 1 and on for page 2 I guess?

Use popUpKey for the rest of the keys, for example the e key can have êéèëēĕěẽėẹęẻ as the popup keys

@Abcd1234-dot
Copy link
Author

Should i create a new PR now? or wait until you and devs finish those core changes you mentioned in another PR?

@ronniedroid
Copy link
Contributor

I myself would recommend you wait for the language selection/filtering and the language toggle (not made a PR yet) to get resolved.

But it is up to you 🙂

@Abcd1234-dot
Copy link
Author

Yeah I will wait then. let me know when those changes are implemented.

@Abcd1234-dot Abcd1234-dot linked a pull request Jan 27, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is about a new feature in the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants