Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream metadata feature from Simple Contacts Pro SE. #53

Closed
5 tasks done
Rexadev opened this issue Jan 23, 2024 · 4 comments
Closed
5 tasks done

Upstream metadata feature from Simple Contacts Pro SE. #53

Rexadev opened this issue Jan 23, 2024 · 4 comments
Labels
invalid This does not seem right

Comments

@Rexadev
Copy link

Rexadev commented Jan 23, 2024

https://github.com/stephanritscher/Simple-Contacts

This extended version (F-Droid, GitHub) of Simple Contacts Pro (F-Droid, GitHub) supports separate address fields for post office box, apartment/suite, street, city, zip code, state and country name.
The extension makes the app compliant with other applications (e. g. Thunderbird with CardBook, iOS Contacts) and cloud services (e. g. Nextcloud) that support the CardDAV and vCard standards (RFC 6352, RFC 6350).

Related to #42

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
@Rexadev Rexadev added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 23, 2024
@Rexadev Rexadev changed the title Upstream metadata from Simple Contacts Pro SE. Upstream metadata feature from Simple Contacts Pro SE. Jan 23, 2024
@Aga-C
Copy link
Member

Aga-C commented Jan 23, 2024

We won't copy someone else's code. If the author of that fork would like to merge his changes to us, we're open for submissions.

@Aga-C Aga-C closed this as completed Jan 23, 2024
@Aga-C Aga-C removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 23, 2024
@Rexadev
Copy link
Author

Rexadev commented Jan 23, 2024

But it is related to the problem #42
@Aga-C

@Rexadev
Copy link
Author

Rexadev commented Jan 23, 2024

@stephanritscher Would you please tell @fossify that they are allowed to use your code

@Aga-C
Copy link
Member

Aga-C commented Jan 23, 2024

We know it's related to that problem, but it doesn't mean that we can accept issues like "copy code from someone else". We're open to contributions, so if someone wants to move that feature and has the original author's approval, that's ok for us.

@Aga-C Aga-C closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2024
@Aga-C Aga-C added the invalid This does not seem right label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This does not seem right
Projects
None yet
Development

No branches or pull requests

2 participants