Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding DiagnosticSource support #203

Open
ejsmith opened this issue Apr 14, 2020 · 2 comments
Open

Consider adding DiagnosticSource support #203

ejsmith opened this issue Apr 14, 2020 · 2 comments

Comments

@ejsmith
Copy link
Contributor Author

ejsmith commented Apr 26, 2020

I added support for tracking correlationid through on queue entries and then did an experiment to make sure that you can add activities and diagnostics for queue entry processing outside of Foundatio. That works. Not sure if we want to take a dependency on System.Diagnostics.DiagnosticSource. I've heard some other people have had trouble with taking on that dependency probably because of the same diamond dependency issue that we have had with JSON.NET and other common libs. I really like that our base nuget package doesn't have a lot of dependencies. We did recently take on a System.Text.Json dependency and that seems like it would be the same issue, but I think the plan there is that hopefully that gets moved into .net standard. Not really sure what is going to happen with .net 5. I heard something about .net standard might be going away somehow.

@ejsmith
Copy link
Contributor Author

ejsmith commented Jun 9, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants