Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store arrays containing null values as sparse arrays across the code #164

Open
dongxinEric opened this issue Apr 16, 2019 · 0 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@dongxinEric
Copy link
Contributor

Right now in insertElementRecursive(), DocLayer does NOT try to store arrays with null values as sparse arrays, i.e. for null value it still insert a k-v for it, which is kind of against what it attempts to achieve later when doing update (skipping the null values and effectively store those arrays as spars arrays). We should make the behavior consistent and do the same in insertion.

@dongxinEric dongxinEric added enhancement New feature or request good first issue Good for newcomers labels Apr 16, 2019
@dongxinEric dongxinEric added this to the 1.7.1 milestone Apr 16, 2019
@dongxinEric dongxinEric self-assigned this Apr 16, 2019
@apkar apkar modified the milestones: 1.7.1, 1.7.3 May 1, 2019
@dongxinEric dongxinEric changed the title Store arrays containing null values are sparse arrays across the code Store arrays containing null values as sparse arrays across the code May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants