-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting customization of tags in the built-in images #387
Comments
We could look at this problem as being similar to what we did for the |
Re-opening this to follow up on the discussion in #587. |
Here's what I've been thinking in terms of how we can make this more flexible. We can create a new field called
When we fill in the images for a built-in containers, we should apply all of the matching rules specified by the This will allow us to support the following scenarios:
If the user specifies an image for the container, but no tag, we should construct the tag based on the rules above. If the user specifies an image with a tag, we should respect that image in full. @johscheuer What do you think? |
The operator does not currently support customizing the tags on the foundationdb and foundationdb-kubernetes-operator image. This can be a difficult limitation in some scenarios:
Allowing arbitrary tags will cause problems when doing upgrades, since the operator needs to carefully manage the image versions to upgrade the sidecar and the main container at the appropriate stages.
This came up in #342, and we addressed the problem by adding stronger validations. I think we should take another look at it and see if there's a cleaner way to support some customization of tags.
The text was updated successfully, but these errors were encountered: