Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define how may Pods should automatically replaced #604

Closed
johscheuer opened this issue Apr 9, 2021 · 1 comment · Fixed by #754
Closed

Allow to define how may Pods should automatically replaced #604

johscheuer opened this issue Apr 9, 2021 · 1 comment · Fixed by #754
Labels
reliability Protections against unsafe behavior, blockers go reconciliation, or other reliability concerns

Comments

@johscheuer
Copy link
Member

Currently we only replace one failed Pod when we enable the feature. I think it makes sense to allow the user to specify how many Pods should/can be replaced.

@johscheuer johscheuer added the reliability Protections against unsafe behavior, blockers go reconciliation, or other reliability concerns label Apr 9, 2021
@johscheuer
Copy link
Member Author

Think about that a little bit we would implement that as some kind of a max inflight replacements which would be the upper limit of replacements for the automatic replacements. If the user would specify 5 that means the controller will evaluate how many process groups are currently marked for removal and if the limit is not reached the controller can replace as many process groups until the limit is reached. A concrete example a user sets the limit to 5 and the operator has 3 ongoing replacements, that means the operator will replace at most 2 process groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reliability Protections against unsafe behavior, blockers go reconciliation, or other reliability concerns
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant