Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectCoordinators should be deterministic #718

Closed
johscheuer opened this issue May 26, 2021 · 0 comments · Fixed by #747
Closed

selectCoordinators should be deterministic #718

johscheuer opened this issue May 26, 2021 · 0 comments · Fixed by #747

Comments

@johscheuer
Copy link
Member

Currently selectCoordinators in the https://github.com/FoundationDB/fdb-kubernetes-operator/blob/master/controllers/change_coordinators.go is not deterministic and returns different coordinators for multiple runs (even when the state is unchanged). That is not a problem currently since the operator only selects new coordinators when the old ones are not valid anymore. We should still change the code to always return a deterministic set of coordinators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant