Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't steal focus to notify people about updates. #1421

Closed
DianaNites opened this issue Mar 18, 2019 · 7 comments
Closed

Don't steal focus to notify people about updates. #1421

DianaNites opened this issue Mar 18, 2019 · 7 comments

Comments

@DianaNites
Copy link

DianaNites commented Mar 18, 2019

This program thinks it's the most important thing in existence and decides it's a good idea to steal focus from whatever you're doing and open itself just to say it has an update.

Don't do that.

@bengotow
Copy link
Collaborator

Haha sorry for the hassle - are you saying the app comes to the foreground? How is it stealing focus exactly?

@DianaNites
Copy link
Author

Yes, it comes to the foreground, that is what stealing focus means, yes.

Whenever there is an update, Mailspring will restore itself from the notification area and force itself to the foreground. Particularly an issue when it decides to do this in the middle of a game. Particularly multiplayer games. Particularly ones that don't like being switched out of.

@bengotow
Copy link
Collaborator

bengotow commented Apr 1, 2019

Ooof that's no good - I guess this is on Windows? Let me see if I can get this fixed.

@bengotow
Copy link
Collaborator

bengotow commented Apr 1, 2019

Hey! Just wanted to follow up - it looks like we can fix this by making the app say "An update has been installed, click OK to restart" similar to the way VSCode does. Unfortunately we need to test this really carefully and make sure it's safe to continue using Mailspring after the update has been installed / without restarting. I'm going to assign myself to this and we'll make the change for the next major release, but there may be an update or two with annoying disruptive restarts until then. Stay tuned!

@DianaNites
Copy link
Author

DianaNites commented Apr 1, 2019

Restarting is fine and unrelated to this issue?

this happens when it notifies you that there is an update available, at which point you can click to install it? But it steals focus to tell you that.

@DianaNites
Copy link
Author

DianaNites commented Apr 5, 2019

Like this, which just stole focus seconds ago. I was in another application, Mailspring opened itself, waited a second or so, and then got around to displaying the notification.

image

@DianaNites DianaNites changed the title Don't steal focus to spam people about updates they don't care about Don't steal focus to notify people about updates. Apr 5, 2019
@CodeMouse92 CodeMouse92 added the audit Auditing issue label Jan 12, 2021
@CodeMouse92
Copy link
Contributor

It appears that there has been no activity on this issue for some time, so we will close it. If the problem occurs again, please create a new thread in the appropriate category on our Discourse.

We are in the process of migrating issues to Discourse, which can better facilitate discussion and discovery, and so GitHub Issues can focus on issues that are confirmed and slated for resolution in the near term. Learn more about the changes here.

We hope to see you there soon!

-The Mailspring Team

@Foundry376 Foundry376 locked and limited conversation to collaborators Feb 11, 2021
@CodeMouse92 CodeMouse92 added stale and removed audit Auditing issue labels Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants