Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Color Code for Account and Favorites Labels/Folders #526

Closed
ccrvlh opened this issue Jan 12, 2018 · 19 comments · Fixed by #2240
Closed

[Feature Request] Color Code for Account and Favorites Labels/Folders #526

ccrvlh opened this issue Jan 12, 2018 · 19 comments · Fixed by #2240

Comments

@ccrvlh
Copy link

ccrvlh commented Jan 12, 2018

Two features that exist in Spark:

  1. Color code for diferent accounts
  2. Possibility to add favorite folders/labels (for gmail)
Are there any related issues?

...

What operating system are you using?

...

What version of Mailspring are you using?

...

--

Bug?

Do you have any third-party plugins installed? If so, which ones?

...

Is the issue related to a specific email provider (Gmail, Exchange, etc.)?

...

Is the issue reproducible with a particular attachment, message, signature, etc?

...

--

Feature Request?

Does this feature exist in another mail client or tool you use?

...

@killtux
Copy link

killtux commented Feb 23, 2018

+1 for that!

customizing the left sidebar would be a big plus:

  • hiding some default folders: "Starred", "Unread", etc...
  • adding some custom imap folders/gmail labels that you want to check regularly (+ unread folder/label counter to see if there is a new message).

for example i get newsletters all day from my suppliers, but i have a gmail filter running that puts them to "news" and skips inbox to have a clear inbox and see really important mails.

in the morning or after work i check the news folder and unread mails if there is something interesting. a intelligent folder option would be nice. for example: set a special folder with the option "only unread mails" and got it added to the sidebar.

of course you can expand the accounts and see all labels. but they wont get checked for new emails till you click it. if you have 3 accounts with lots of labels there is a lot of scrolling needed. most labels you dont need on a daily base.

@readsquirrel
Copy link

readsquirrel commented Mar 2, 2018

Yes, +1 to both requests!

  • I don't use Archive at all, so the ability to hide the folders would be great. Also, I don't need my SPAM folder to be that prominent.
  • The ability to put favorite folders in the top section for Office 365 would also be great. There are some folders that are in a particular place in the folder tree logically but that I either check frequently or file documents into frequently. Having them as favorites at the top makes both easier.

@aulbricht
Copy link

Having customizable account colors -- such that each email in the combined inbox has a little corresponding account color bar next to it, or similar -- is huge for those of us who deal with multiple email accounts! Please implement.

@CarlosRebolledoA
Copy link

+1

1 similar comment
@artsgirl
Copy link

+1

@twilight-sparkle-irl
Copy link

Just set Mailspring up and this was the first thing I noticed wasn't a thing. C'mon.

@eclectic-coding
Copy link

I agree. This is a feature in SparkMail which is a wonderful helper. I would liek to see this added to MailSpring.

@gatiba
Copy link

gatiba commented Oct 6, 2019

+1

@math-uzh
Copy link

+1 favorite folders and colored accounts would be wonderful

@meesrutten
Copy link

+1

2 similar comments
@intheravine
Copy link

+1

@skobylite
Copy link

+1

@ChitranshuV
Copy link

+1 Color code for different accounts.

@jesi-rgb
Copy link

+1 in color coding different accounts. That is a feature in Spark, a iOS and MacOS based client, and it works beautifully.

@moatus
Copy link

moatus commented Oct 5, 2020

+1 plus the ability to customize the color of labels.

@Phylu
Copy link
Contributor

Phylu commented Dec 6, 2020

I will have some time at the beginning of next year and would like to try working on this feature. This is something which is most important for me with my mail clients, and I would love to give it a shot. I think the following two issues are bascially asking for similar functionality as well:

I am thinking about the following:

  1. In Settings > Accounts add a selector (e.g. color picker) for the account color.
  2. In the main view adjust the background color of the e-mail preview tile accordingly

Are there any important things that I should keep in mind (in addition to https://github.com/Foundry376/Mailspring/blob/master/CONTRIBUTING.md)? Any pointers to the code that may be helpful are also totally welcome.

@Phylu
Copy link
Contributor

Phylu commented Dec 26, 2020

I managed to get a first prototype working (https://github.com/Phylu/Mailspring/tree/feature/526-colorize-accounts). I am happy to receive some feedback on it.

Screenshot 2020-12-26 at 20 08 43

Screenshot 2020-12-26 at 20 09 44

@ZachariahRosenberg
Copy link

ZachariahRosenberg commented Dec 27, 2020

@Phylu Well done and thank you for working on this.

The label design you have here is on the full left border, which means that from a design hierarchy, it is ambiguous whether the label is within the message box versus part of the parent component.

This becomes an important distinction when we include the message list "swipe functions":

Screen Shot 2020-12-27 at 12 23 41 PM

*screen capture of current swipe UI*

The swipe UI - the green archive - is not inside of the message box, but sort of underneath it. That star (in the same img above) is clearly inside the message box, so it is clear that it is tied to that message box (and when swiped to the archive, will go along with it).

Screen Shot 2020-12-27 at 12 29 19 PM

*mockup of account label with swipe UI. It's ambiguous whether the account label is part of the message box, the swipe action, or another message list feature*

With swipe actions, it becomes important to distinguish which UI elements are included inside the message box versus which aren't. The account label should be included with that specific message box (and when swiped, is swiped along with the rest).

That is why it might be best to follow something similar to spark where it is a smaller color indication inside the message box:

Screen Shot 2020-12-27 at 12 27 39 PM

Alternatively, since I like the way your mockup looks, you can add a strong left border, reduce the label height by a few pixels on both top/bottom, which will make the label appear to be part of the message...

@Phylu
Copy link
Contributor

Phylu commented Dec 27, 2020

@ZachariahRosenberg Thanks for the design hint. I think having it similar to spark is looking better than adding a border left of the element (and easier to implement as well). have updated this accordingly:

Screenshot 2020-12-27 at 20 28 06

@Foundry376 Foundry376 locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.