Skip to content
This repository has been archived by the owner on May 4, 2023. It is now read-only.

Improving Layout For App #39

Closed
ThePrimalPea opened this issue Jan 27, 2022 · 20 comments
Closed

Improving Layout For App #39

ThePrimalPea opened this issue Jan 27, 2022 · 20 comments
Labels
enhancement New feature or request resolved Issue has been resolved

Comments

@ThePrimalPea
Copy link

MOVE THE SEARCH BUTTON

Move search button

I suggest move the search button out of the app corner a little bit, it's will look better for rounded corner devices. Mostly all apps left the search button in the right side.

EXTEND THE SEARCH BAR

Full bar

The search bar should be longer to look fit with the screen

@Fox2Code Fox2Code added enhancement New feature or request help wanted Extra attention is needed labels Jan 27, 2022
@Fox2Code
Copy link
Owner

While I'm a long time java developer and have experience with root, I'm not really good at making good UIs.

While I'm improving, this will probably not happen any time soon.

Same problem with the #34 request.

@Madis0
Copy link
Contributor

Madis0 commented Jan 29, 2022

I don't think it fits to the right because it would cover the toggle, delete and link buttons.
Would be better to just keep it in the top bar like Play Store or YouTube.

@samyakbardiya
Copy link

samyakbardiya commented Jan 29, 2022

would like to suggest some more things related to layout: make the Download/Install button and Info button, bigger and separate them out further.

It has happened with me a few times, I wanted to see the info but pressed the other button by mistake and boom, the module was installed.

edit: I don't know if I should make a new issue for this or writing it here was okay, if a new issue is to be made then please inform me, I'll create a new one.

@Fox2Code Fox2Code added wontfix This will not be worked on and removed help wanted Extra attention is needed labels Jan 31, 2022
@Fox2Code
Copy link
Owner

If someone want to do the changes, why not, but I'm not doing it.
I already struggle with the UI enough.

@Fox2Code Fox2Code pinned this issue Jan 31, 2022
@Fox2Code Fox2Code added the help wanted Extra attention is needed label Jan 31, 2022
@Fox2Code
Copy link
Owner

Yeah I definitely need help.

@nift4
Copy link
Collaborator

nift4 commented Feb 2, 2022

Hey, I can offer some help in making the UI a bit more material design, if you want I can also move the UI to jetpack compose & kotlin, lmk if you are interested

@Fox2Code Fox2Code removed the wontfix This will not be worked on label Feb 3, 2022
@Fox2Code
Copy link
Owner

Fox2Code commented Feb 3, 2022

Telegram -> https://t.me/Fox2Code_Chat
I will definitely try to improve the app UI.

@Electric1447
Copy link

You should also add padding to the recyclerview items, and change the search icon to a solid color fab.

I will add a pull request when I have some time

@Fox2Code
Copy link
Owner

Fox2Code commented Mar 7, 2022

@Electric1447 the was already change with RC-1.
Please join telegram for community feedback:
https://t.me/Fox2Code_Chat

@DerGoogler
Copy link
Contributor

I have fixed the darkmode in #107

@Fox2Code
Copy link
Owner

There is no fix, there is only improvement. Nothing is perfect, but everything can be better.
Especially when talking about user interface because everyone have their personal preferences.

@nikolowry
Copy link

Ever since UI updates started to be pushed, I've been encountering an issue with the app bar (see screen recording): https://neeks.me/cloud/index.php/s/GxDdNgqCHntf9gy

Device: Pixel 5
OS: ProtonAOSP 12.3.1 (12L)

@DerGoogler
Copy link
Contributor

Ever since UI updates started to be pushed, I've been encountering an issue with the app bar (see screen recording): https://neeks.me/cloud/index.php/s/GxDdNgqCHntf9gy

Device: Pixel 5 OS: ProtonAOSP 12.3.1 (12L)

Looks like device depend. I facing no issues on Pixel Experience rom.

@Fox2Code
Copy link
Owner

@nikolowry I tried to fix it in c3d8213 but no guarantee it will fix the issue.

@nikolowry
Copy link

@nikolowry I tried to fix it in c3d8213 but no guarantee it will fix the issue.

Just updated to https://github.com/Fox2Code/FoxMagiskModuleManager/releases/tag/0.4.4, but unfortunately the issue was not fixed. Thanks for the speedy attempt though, feel free to @ me if you want me to check again

@androidacy-user
Copy link
Collaborator

I consider this done with the monet update. @Fox2Code feel free to reopen if you feel otherwise.

@androidacy-user androidacy-user added resolved Issue has been resolved and removed help wanted Extra attention is needed labels Jun 15, 2022
@androidacy-user androidacy-user unpinned this issue Jun 15, 2022
@nikolowry
Copy link

@Fox2Code I was able to pinpoint my issue, it's due to an atypical device configuration. I prefer to set my Pixel 5 "Font-Size" to "Small" and "Display" to "Default". Attaching a video demonstrate: https://neeks.me/cloud/index.php/s/z2sxTKXAfWrb5Zi

I don't usually target Android in my daily development life, but maybe Layout Inspector and Layout Validaton could help: https://developer.android.com/studio/debug/layout-inspector

@Fox2Code
Copy link
Owner

Making layout adapt to every devices take time, I just put assumptions on layout to not take too long to release the next update, I prefer making releases faster, even if it contains some bugs.

@nikolowry
Copy link

@Fox2Code there are thousands of different device configurations, so I was not suggesting to target my specific configuration -- but rather figure out the "right way" to calculate UI dimensions:

@nikolowry
Copy link

Happy to report the DPI issues I was experiencing has been resolved in one of the latest releases. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request resolved Issue has been resolved
Projects
None yet
Development

No branches or pull requests

9 participants