Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jeffs comments on promos #2298

Closed
bagratinho opened this issue Jun 26, 2017 · 2 comments
Closed

Jeffs comments on promos #2298

bagratinho opened this issue Jun 26, 2017 · 2 comments

Comments

@bagratinho
Copy link
Contributor

bagratinho commented Jun 26, 2017

Copied from : #2116 (review)

Found a couple things that we should change:

  • For item qualifiers, give an option for any product to qualify

  • Change text of "Items for qualify" to "Qualifying items"

    foxcommerce_-_new_promotion
  • This UX feels pretty confusing -- what does it mean?

    foxcommerce_-_new_promotion
  • We don't seem to be forcing a choice on usage rules. What does this state mean?

    foxcommerce_-_jeff_s_auto_applying_yo
  • I set my offer on a promotion to be free shipping, it appears that I'm going to be charged shipping, even though I'm not

    foxcommerce_-_cart_br10005
  • If an exclusive promotion is on the cart and I try to add a promotion that is not exclusive, it kicks the exclusive promotion off

We don't necessarily need to fix up all of this, but wanted to highlight the issues.

@bagratinho
Copy link
Contributor Author

Some of those are fixed here - #2300

@annappropriate
Copy link
Contributor

I split this into #2304 #2305 #2306 #2307 #2308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants