-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking menu item prevents control bar from hiding. #8
Comments
A workaround or possibly even a pointer as to why the control bar gets 'stuck' in the visible condition, is that by setting 'disableAuto': true, seems to allow the menu items to be repopulated after a selection has been made without affecting the control bar's visibility and thus having it hide as it should with no activity. |
Well I was just about to report this very issue. Is there any update on this? |
This is probably not part of the issue but the condition doesn't seem right. It will always be true, In changeLevel method the value is always true for obj.enabled.
|
I'll pick up both issues shortly, 🎄! @tolew1 can you create another issue for that bug for tracking purposes? I'm cool with creating it and mentioning you there. |
My bad for taking long to respond to this. I created another issue. Any movement on the quality switcher issue? |
Any updates on this issue? I can confirm that it is still an issue in VideoJS v7.11.6. |
I can't seem to reproduce the issue @bman46 @tolew1 @YouGitIt. Every permutation of my settings and selections seems to have VideoJS's control bar fading away successfully. Note: The test page for the plugin videojs-max-quality-selector/index.css Line 30 in cfbe197
I'll continue to try and reproduce the bug; in the meantime, can y'all confirm there isn't some extra CSS forcing the controlBar visible? |
For me it usually works as expected but i think it may have something to do with when VideoJS blacklists a HLS stream that a user selected. I cannot confirm this is the cause because it doesn't happen very frequently and I haven't looked into it too much when it does occur. |
For what its worth, I was experiencing this same problem but I had a few modifications that I made to the script that may have been contributing to the issue. I narrowed it down to the Moving the function call that eventually made the At the same time, I think I tracked down a way to fix it in video.js itself videojs/video.js#7383 |
After clicking on one of the menu items the control bar won't 'auto hide' any more. Clicking the main button does not result in the same behavior, just clicking a menu item does.
The expected behavior should be that after you click on a different resolution menu item than what the 'Auto' pre-selects, the control bar should continue to act as expected and auto hide(fade away) once the mouse has left the area of the video.
The text was updated successfully, but these errors were encountered: