Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking menu item prevents control bar from hiding. #8

Open
YouGitIt opened this issue Sep 28, 2020 · 9 comments
Open

Clicking menu item prevents control bar from hiding. #8

YouGitIt opened this issue Sep 28, 2020 · 9 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@YouGitIt
Copy link

After clicking on one of the menu items the control bar won't 'auto hide' any more. Clicking the main button does not result in the same behavior, just clicking a menu item does.
The expected behavior should be that after you click on a different resolution menu item than what the 'Auto' pre-selects, the control bar should continue to act as expected and auto hide(fade away) once the mouse has left the area of the video.

@YouGitIt
Copy link
Author

A workaround or possibly even a pointer as to why the control bar gets 'stuck' in the visible condition, is that by setting 'disableAuto': true, seems to allow the menu items to be repopulated after a selection has been made without affecting the control bar's visibility and thus having it hide as it should with no activity.
The obvious negative here is that you no longer can use 'Auto'.

@FoxCouncil FoxCouncil self-assigned this Oct 18, 2020
@FoxCouncil FoxCouncil added bug Something isn't working help wanted Extra attention is needed labels Oct 18, 2020
@tolew1
Copy link

tolew1 commented Oct 31, 2020

Well I was just about to report this very issue. Is there any update on this?

@tolew1
Copy link

tolew1 commented Oct 31, 2020

This is probably not part of the issue but the condition doesn't seem right. It will always be true,

In changeLevel method the value is always true for obj.enabled.

 if (levelIndex < 0) {
      this.qlInternal.levels_.forEach(function(obj, idx) {
        if (self.options.minHeight !== 0 && obj.height >= self.options.minHeight || self.options.maxHeight !== 0 && obj.height <= self.options.maxHeight) {
          obj.enabled = true;
        } else {
          obj.enabled = true;
        }
      });
      this.update();
      return;
    }

@FoxCouncil
Copy link
Owner

I'll pick up both issues shortly, 🎄!

@tolew1 can you create another issue for that bug for tracking purposes? I'm cool with creating it and mentioning you there.

@FoxCouncil FoxCouncil added this to the Version 1.0.0 milestone Dec 6, 2020
@tolew1
Copy link

tolew1 commented Jan 14, 2021

My bad for taking long to respond to this. I created another issue. Any movement on the quality switcher issue?

@bman46
Copy link

bman46 commented Mar 10, 2021

Any updates on this issue? I can confirm that it is still an issue in VideoJS v7.11.6.

@FoxCouncil
Copy link
Owner

I can't seem to reproduce the issue @bman46 @tolew1 @YouGitIt.

Every permutation of my settings and selections seems to have VideoJS's control bar fading away successfully.

Note: The test page for the plugin npm run start forces the control bar to be visible always here:

opacity: 1 !important;

I'll continue to try and reproduce the bug; in the meantime, can y'all confirm there isn't some extra CSS forcing the controlBar visible?

@bman46
Copy link

bman46 commented Apr 8, 2021

For me it usually works as expected but i think it may have something to do with when VideoJS blacklists a HLS stream that a user selected. I cannot confirm this is the cause because it doesn't happen very frequently and I haven't looked into it too much when it does occur.

@jgcaruso
Copy link

jgcaruso commented Aug 18, 2021

For what its worth, I was experiencing this same problem but I had a few modifications that I made to the script that may have been contributing to the issue.

I narrowed it down to the button.update() call occurring at the same time as a bunch of other player commands I was making at the same time (like player.currentTime(), player.play()).

Moving the function call that eventually made the button.update() call into a setTimeout with 0 duration fixed the issue for me in Firefox and Chrome, but not Safari... incase that helps narrow down the issue.

At the same time, I think I tracked down a way to fix it in video.js itself videojs/video.js#7383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants