-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"non-actioned" events #41
Comments
It's a good idea but the blocking issue for this is scaling. For low-volume subreddits this would be a non-issue but CM runs on subreddits which do checks daily across 13k-30k activities. It's not feasible to hold all of those results in memory (the default cache/store configuration). Redis would work but still doesn't scale across multiple days...I've got one subreddit that's done 9.6 million activities in the last month. Issues I see with this and some off-the-cuff remedies: ScalingHow to store results in a way that works from 10 to 10k activities per day?
Finding useful informationAt lower volumes it should be easy to find the result you are looking for. But at higher volumes will need to be able to filter results or else it'll be as useless as fast logging for high-volume subreddits
Additionally, may be prudent to fold all results to this change. So actioned/non-actioned alike. Then actioned can just be another filter (maybe still store separately so tailing limit doesn't apply?) Retaining useful informationA user may want to retain a certain result but if the tailing limit is low or subreddit is high volume it could potentially be dropped quickly. Will need a way to store and retrieve user-defined results. |
I’ll expand more into this but redis. It’ll mean using redis. I’ve dealt with this kind of volume. The other option would be to allow this to be enabled/disabled so smaller subs or subs needing to debug can use it. |
Implemented in 0.11.0 using Recording Options |
I'd like to see a page with the results for every check that's run as well as a button to rerun the check on that post/comment.
The text was updated successfully, but these errors were encountered: