Changelog

[julkue]

Where can I find the changelog of the two most recent versions? On the Github releases page, there's no description for the latest change which seems to be quite hughe from a files diff perspective.

[julkue]

It also seems like the dist file with the umd suffix isn't generated in v1.1.0 compared to v1.0.6, so actually this is a breaking change and from my opinion should have been a reason for v2.0.0.

Reference

[julkue]

It also seems like the main property in the package.json points to an invalid file. Within the dist folder there's no "mmenu.js" file, only "mmenu-light.js". And importing the file directly using:

import MmenuLight from 'mmenu-light/dist/mmenu-light';

results in an empty object. Seems like it's now required to use window.MmenuLight (ugly)? There also seems to be an inconsistency between naming dist CSS and JS files (mmenu-light.js vs mmlight.css)

[julkue]

I think it would be worth providing a live example on the plugin's homepage to see off canvas / normal in action. It's very hard for me currently to get everything up and running. Pasting the tutorial code into jsfiddle also doesn't seem to generate a proper example: Fiddle

[julkue]

When scrolling, the new version doesn't seem to keep the border. So the border bottom of "Menu" will disappear when srolling. Couldn't see this on the website itself, does it use the most recent version?

Before scrolling:

After scrolling:

[FrDH]

one question per issue please

[julkue]

@FrDH Ok, I will consider this for the future. Would you mind to answer to the issues above?

[FrDH]

• There is no changelog as untill yesterday there were no changes. I'll add a changelog shortly. As this plugin in still in its infancy, big changes are unavoidable.
• I'll update the package.json (sorry for the inconvenience). The main property should point to the plain .js script, the module property should point to the module.
• I'll see if I can fix the border issue.

[julkue]

Thanks for your reply.

As this plugin in still in its infancy, big changes are unavoidable.

Please consider releasing a new major version if there are changes that will break an existing implementation:
https://semver.org/

[FrDH]

You're right. Give 2.0.0 a try