DEVREL-234, DEVREL-235, DEVREL-250: CircleCI setup, integration testing, improved dev tooling, and CODEOWNER setup #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump version Fix typo Improve version bumper Fix starting version Bump version: 0.6.0 → 0.7.0 Bump version: 0.7.0 → 0.7.1 Fix current version and add bump-patch Fix current version Bump version: 0.6.0 → 0.7.0 Fix shebang
Fix formatting Switch docker image for build Add debug Add orb More debugging List files Add checkout step Disable version verification for now Modify persist to workspace Update pip install settings Change installation dir Tweak deploy command
Save build artifact to debug Add CircleCI installer to makefile and git hook Purposefully break to test git hook Finish testing pre-commit hook Update directories Fix integration test Tweak formatting Integrate download function Prevent paginating responses that don't need it Ask for asset_children correctly Improve pagination handling Tweak integration test and pass asset correctly Fix upload path management Fix file paths again
Finish verification code Add Python 3.7 test Increase verobosity in integration test Fix python 2/3 cmp() function problem Debug python version comparison Continue to debug python versions Finished test! Add test for latest python version Add linux 3.6.5 Improve test naming Make universal package Modify asset print Attempting to debug python 2.7 Add more debugging for py 2.7 Improve debug verbosity Remove debugging for uploader Seperate py2 and py3 uploaders Remove version limitations Remove extraneous print and add cleanup task Add python version to Frame.io folder name Try again with new assets
This was referenced Apr 15, 2020
ThomasSzabo
approved these changes
Apr 24, 2020
|
Proposal: |
This is a good idea, I've been thinking about doing this as well. It will make deployment and CircleCI stuff much easier. |
jhodges10
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR that adds a lot.
The big item is CircleCI setup and testing for Python 2.7, 3.7.7, and 3.8+ (latest tag).
There is now an integration test that tests both upload and download across that version matrix and makes sure that it succeeds before allowing code to merge into the master branch.
There's also a Makefile now which includes functions for bumping the version up using semver syntax as well as tagging the version for git.
If the version tag doesn't match the version in the setup.py file then it will not pass testing (disabled for now due to issues with the
CIRCLE_TAGenvironment variable).CircleCI will only run the deploy stage on the
masterbranch.This also separates our upload functions for Python 2 and 3 (and adds one for python 3!), as well as fixes some small bugs in the Python 2 uploader, and improves the PaginatedResponse object logic so it only returns a PaginatedResponse when there's actually more than 1 page of results, and not just every time results could potentially be paginated.
Closes DEVREL-234, DEVREL-235, DEVREL-250.