Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Sentry "report issue" popup from showing up when token expires #989

Closed
1 task
smadbe opened this issue Apr 5, 2022 · 1 comment · Fixed by #995
Closed
1 task

Prevent Sentry "report issue" popup from showing up when token expires #989

smadbe opened this issue Apr 5, 2022 · 1 comment · Fixed by #995
Assignees

Comments

@smadbe
Copy link
Contributor

smadbe commented Apr 5, 2022

Overview

When left open for a long time (e.g. computer reopened), sessions (typically anonymous ones as there are 2h-long I think) cause a 401 when trying the extend the cookie lifetime and it is too late. The behavior is normal but the a Sentry modal is displayed in this case, which should not be the case.

Acceptance criteria

  • Don't display the sentry modal when an anonymous session expires and receive a 401.
@smadbe smadbe added this to the Toward a first working version milestone Apr 5, 2022
@smadbe smadbe changed the title Prevent Senty "report issue" panel when token expires Prevent Senty "report issue" panel from showing when token expires Apr 5, 2022
@smadbe smadbe changed the title Prevent Senty "report issue" panel from showing when token expires Prevent Sentry "report issue" popup from showing up when token expires Apr 12, 2022
@smadbe
Copy link
Contributor Author

smadbe commented Apr 12, 2022

As discussed, also include the following change:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants