Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Videos and Projects Pages Need a Loader #431

Closed
tobySolutions opened this issue Dec 14, 2022 · 9 comments
Closed

[FEATURE] Videos and Projects Pages Need a Loader #431

tobySolutions opened this issue Dec 14, 2022 · 9 comments
Assignees

Comments

@tobySolutions
Copy link
Collaborator

Description

The Loader (That stuff that rolls when you go to a page that hasn't fully loaded) should be conditionally rendered. The Loader should only be removed when all the resources have been fetched.

Screencast.from.14-12-2022.14.41.43.webm

Screenshots

Screenshot from 2022-12-14 14-41-36

@tobySolutions
Copy link
Collaborator Author

Anyone wants to do this??

@Schleidens
Copy link
Contributor

Assign it to me Toby :)

@tobySolutions
Copy link
Collaborator Author

Awesome @Schleidens!! Have fun!!

@tobySolutions
Copy link
Collaborator Author

How far have you gone with this @Schleidens??

@Schleidens
Copy link
Contributor

I added the loader it works pretty well. But the Youtube component still taking time to render.
I'm trying another way, i'll reach you in the discord server.

Thank you for taking care @tobySolutions 👐🏽😌

@tobySolutions
Copy link
Collaborator Author

I added the loader it works pretty well. But the Youtube component still taking time to render.
I'm trying another way, i'll reach you in the discord server.

Thank you for taking care @tobySolutions 👐🏽😌

Sure thing @Schleidens!! 💙💙

@Schleidens
Copy link
Contributor

I added the loader it works pretty well. But the Youtube component still taking time to render.
I'm trying another way, i'll reach you in the discord server.
Thank you for taking care @tobySolutions 👐🏽relieved

Sure thing @Schleidens!! blue_heartblue_heart

Done @tobySolutions you can close this now

@tobySolutions
Copy link
Collaborator Author

No, this issue is still very much open @Schleidens.

@tobySolutions
Copy link
Collaborator Author

I think you're right @Schleidens.
Fixed by #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants