Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let DiscordVoiceConnections be reused #108

Open
Francessco121 opened this issue Jan 31, 2023 · 0 comments
Open

Let DiscordVoiceConnections be reused #108

Francessco121 opened this issue Jan 31, 2023 · 0 comments
Labels
enhancement New feature/content

Comments

@Francessco121
Copy link
Owner

Francessco121 commented Jan 31, 2023

At the moment, DiscordVoiceConnections become "invalid" if anything goes wrong or if they disconnect for any reason. This makes the class a bit clunky to use.

This is a proposal to:

  • Remove the concept of voice connection invalidation
  • Let "fatal" errors simply disconnect the connection
  • Add better automatic reconnection where possible

With this change, DiscordVoiceConnections would be able to simply be created for each guild and live for the entire duration of the associated bridge. This massively simplifies usage, but would be a pretty large breaking change.

Note: The only "invalid" state should be when the class is disposed.

@Francessco121 Francessco121 added the enhancement New feature/content label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature/content
Projects
None yet
Development

No branches or pull requests

1 participant