Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

web builder does not emit sourcemaps (?) #26

Closed
davibe opened this issue Mar 15, 2019 · 6 comments
Closed

web builder does not emit sourcemaps (?) #26

davibe opened this issue Mar 15, 2019 · 6 comments

Comments

@davibe
Copy link

davibe commented Mar 15, 2019

No description provided.

@sant123
Copy link

sant123 commented Mar 15, 2019

Seems it only works with inline sourcemaps. Take a look at this .babelrc file:

{
  "sourceMaps": "inline"
}

@davibe
Copy link
Author

davibe commented Mar 15, 2019

.babelrc does not have any effect.

I was able to generate sourcemaps by adding a rollup() parameter: sourcemap: true right here https://github.com/pikapkg/builders/blob/master/packages/plugin-build-web/src/index.ts#L60

The problem now is that the source maps are referring to pkg/dist-src and not my real sources src/index.ts. This breaks for example visual studio code debugging.

@FredKSchott
Copy link
Owner

+1, we should add sourcemap: true to be the default behavior for all rollup-powered builders (web, node, etc).

@backspaces
Copy link

I would love an option to not generate source maps for pika/web. I have to delete them!

@bendtherules
Copy link

bendtherules commented Jul 2, 2019

Any updates on this?

Sourcemaps are an important part of any build tool - to play nice with other existing tools. For ex., test coverage tools will show lower test coverage after pika build, just because it has boilerplate code and they can't map back to the original files.

@FredKSchott Would love to contribute this, if there is some consensus.

@FredKSchott
Copy link
Owner

FredKSchott commented Jul 26, 2019

Support was just added (see the relevant READMEs), and will go out with the next v0.6.0 release. We'll also be turning sourcemaps on by default, since they don't affect build-time and are important to many consumers. Thanks everyone for your patience on this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants