JSON imports not working with Snowpack 2.18.0.

[heikkilamarko]

I have the following JSON imports in my code:

import en from 'apexcharts/dist/locales/en.json';
import fi from 'apexcharts/dist/locales/fi.json';

This works okay with snowpack version 2.17.1.

After upgrading to snowpack version 2.18.0, I started to receive the following errors in browser console and my app is not starting:

[antony]

I feel like this relates to my isssue #1814 perhaps

[coderbyheart]

Same problem here. Upgrading from 2.17.1. to 2.18.0 breaks the app:

2.18.0 response

2.17.1 response

You can see the content-type has changed for the same file.

[jason0x43]

I am also seeing this issue with 2.18.0, where 2.17.1 worked fine.

I did notice that with 2.18.0, CSS files are properly typed -- they end up as whatever.css.proxy.js with a MIME type of application/javascript. So not all non-JS imports are broken.

[FredKSchott]

I can reproduce, looking now into why. It's strange because ./foo.json works just fine on my machine, so it seems to effect npm package JSON imports only.

[FredKSchott]

Fix: #1834
Apologies for the regression! Adding a test now to catch this in the future (we had one for local JSON imports, but not from npm packages)

[cgrinds]

Thanks @FredKSchott I applied your patch to my 3.0 release branch where I was seeing the same error as coderbyheart. With your patch, the behavior has improved, in that the mime-type is correct now, but the import still looks wrong. This may be Svelte related, not sure.

My Svelte TypeScript app has this import:

import {push} from "svelte-spa-router";

No errors when running snowpack dev. The error overlay shows

Unhandled Runtime Error
SyntaxError: import not found: push

When I check the dev console, the request that matches the import is made
http://localhost:9779/web_modules/svelte-spa-router.svelte.proxy.js but the response looks wrong (or at least doesn't match the "shape" of other requests that contain the correct content.

This is the full response for http://localhost:9779/web_modules/svelte-spa-router.svelte.proxy.js

export default "/web_modules/svelte-spa-router.svelte";

I don't have a standalone, but can try to put one together if you need.

[FredKSchott]

You're right, I can reproduce. Looking now...

[FredKSchott]

Okay, this appears to be a separate bug where we're treating the package's Svelte entrypoint (svelte-spa-router/Router.svelte) as an asset, and not a file to be built. I'll prioritize a fix for this.

Curious: was this package working in older versions for you? The bug appears to have existed for a while in the esinstall codebase, and I can't see what would have caused a regression in this version. But, we did just refactor this part of the codebase recently, so it's likely that I'm missing something in the diff.

Thanks for the help catching these!

[cgrinds]

Curious: was this package working in older versions for you?

Yes it's currently working in snowpack": "^2.17.1" and by working I mean I see svelte-spa-router.js in the web_modules directory and the Svelte routing works as expected at runtime.

[FredKSchott]

Okay great. @drwpow lets fix this early next week. svelte-spa-router points to a Router.svelte file, which should be treated as a "JS" file for the purpose of this install (since the svelte+rollup plugin is used, .svelte can be installed).

The new logic flow in esinstall resolution causes this to be treated like a non-JS assets and just copied over directly into the web_modules dir.