Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @snowpack/plugin-webpack to Webpack 5 #1381

Closed
eligrey opened this issue Oct 22, 2020 · 6 comments
Closed

Upgrade @snowpack/plugin-webpack to Webpack 5 #1381

eligrey opened this issue Oct 22, 2020 · 6 comments

Comments

@eligrey
Copy link

eligrey commented Oct 22, 2020

Is @snowpack/plugin-webpack planned to be updated to Webpack 5?

@eligrey eligrey changed the title Upgrade @snowpack/plugin-webpack to Webpack 5.0 Upgrade @snowpack/plugin-webpack to Webpack 5 Oct 22, 2020
@drwpow drwpow added contributors welcome! contributors welcome! good first issue Good for newcomers labels Oct 27, 2020
@drwpow
Copy link
Collaborator

drwpow commented Oct 27, 2020

Yes! We’d love a PR if anyone is able to provide one.

@N8-B
Copy link
Contributor

N8-B commented Oct 29, 2020

@drwpow - I could try to tackle this. Feel free to assign this issue to me given you agree with the following caveat.

This plugin uses webpack-manifest-plugin which currently is not compatible with webpack 5. If we want to update to webpack 5, the plugin's manifest option would have to fallback to false internally until the manifest plugin offers webpack 5 support (see migration plan).

@FredKSchott
Copy link
Owner

Bah, that's a shame. We may just want to wait, then

@FredKSchott
Copy link
Owner

@shellscape
Copy link

An update for you all here: shellscape/webpack-manifest-plugin#222 (comment)

@FredKSchott
Copy link
Owner

Thanks @shellscape! I'm going to close this issue on our end for now, since we use our issue tracker for prioritized tasks only and it sounds like the Webpack v5 ecosystem (and webpack core, to an extent) needs a bit more time to settle. Will reopen when we have the time & when it feels safe to upgrade (probably post Snowpack v3 launch).

In the meantime, I believe that there is a discussion in our discussion forum where we can continue to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants