Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 RFC: Pass target option tgo esbuild transform call #3541

Closed
1 of 3 tasks
melink14 opened this issue Jul 6, 2021 · 1 comment
Closed
1 of 3 tasks

💡 RFC: Pass target option tgo esbuild transform call #3541

melink14 opened this issue Jul 6, 2021 · 1 comment

Comments

@melink14
Copy link

melink14 commented Jul 6, 2021

Motivation

Simplification of the build pipeline by not requiring esbuild optimization after esbuild transformation in order to target something other than esnext

Proposed solution

Possible solutions

esbuild transform already takes target so passing it is easy enough. It's currently only surfaced in optimize section of config but it seems like it would fit well into buildOptions as well.

Risks, downsides, and/or tradeoffs

Having target in two places might be confusing since it doens't make too much sense to have them differ.

Detailed design

No response

Open questions

No response

Help make it happen!

  • I am willing to submit a PR to implement this change.
  • I am willing to submit a PR to implement this change, but would need some guidance.
  • I am not willing to submit a PR to implement this change.
@drwpow
Copy link
Collaborator

drwpow commented Jul 8, 2021

We are already considering this! This will be a part of our planned Snowpack v4 work, hinted at by the “multi-platform targeting.” This is a major (breaking) change, so we can’t ship something easily in 3.x with one PR.

I’m going to close this issue as it’s already planned/captured elsewhere, but TL;DR we agree 🙂

@drwpow drwpow closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants