Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import resolver breaks on complex dynamic import inside of web_modules #554

Closed
FredKSchott opened this issue Jun 30, 2020 · 1 comment · Fixed by #785
Closed

Import resolver breaks on complex dynamic import inside of web_modules #554

FredKSchott opened this issue Jun 30, 2020 · 1 comment · Fixed by #785
Labels
bug Something isn't working contributors welcome! contributors welcome!

Comments

@FredKSchott
Copy link
Owner

Original Discussion: https://www.pika.dev/npm/snowpack/discuss/398
/cc @zalelion

  [error] [404] /web_modules/common/%22%20+%20bundleId%20+%20%22.entry.js%22%20+%20'.js
    ✘ /Users/liangzeng/Documents/web/node_modules/.cache/snowpack/dev/common/" + bundleId + ".entry.js" + '.js
    ✘ /Users/liangzeng/Documents/web/node_modules/.cache/snowpack/dev/common/" + bundleId + ".entry.jsx" + '.js
    ✘ /Users/liangzeng/Documents/web/node_modules/.cache/snowpack/dev/common/" + bundleId + ".entry.ts" + '.js
    ✘ /Users/liangzeng/Documents/web/node_modules/.cache/snowpack/dev/common/" + bundleId + ".entry.tsx" + '.js
    ✘ /Users/liangzeng/Documents/web/node_modules/.cache/snowpack/dev/common/" + bundleId + ".entry.js" + '.jsx

We are supposed to be ignoring complex dynamic imports like this (import('foo'+bar+'baz.js')) but it appears our REGEX for matching against complex imports is broken.

@FredKSchott FredKSchott added bug Something isn't working contributors welcome! contributors welcome! labels Jun 30, 2020
@FredKSchott
Copy link
Owner Author

See also: #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contributors welcome! contributors welcome!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant