Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to instructions for how to update packages for Pika CDN (with smart suggestions?) #56

Closed
karlhorky opened this issue Jun 13, 2019 · 5 comments

Comments

@karlhorky
Copy link

karlhorky commented Jun 13, 2019

Hello, first of all, thanks for this project! It's cool to see more work being done in the area of ES Modules and bundlers!

I searched for a package today that didn't fulfill the necessary requirements for inclusion in the Pika CDN (search link), and got a partially-helpful error message:

Screen Shot 2019-06-13 at 11 16 53

This is a good start! But it would be nice for package authors and other open source users to have a link to a minimal, best-practices guide for how to update packages to support the necessary requirements.

I've since opened miracle2k/react-arrow#6 to update the field in package.json, but am uncertain if this is the only change necessary.


Bonus: Would be cool to have a matching heuristic for this that looks for existing configuration files / config in package.json and makes better recommendations based on the existing bundler.

@FredKSchott
Copy link
Owner

bundlephobia has a cool "similar packages" feature that would be interesting to pull from: https://bundlephobia.com/result?p=moment@2.24.0

@karlhorky
Copy link
Author

karlhorky commented Jul 26, 2019

@FredKSchott I'm not sure if we're understanding each other properly - this issue is not a request to improve the search for alternative or similar packages, rather it is about improving the documentation / guide / tips for authors of packages which do not fulfill the requirements.

But maybe I missed something about that feature that you mentioned...

@FredKSchott
Copy link
Owner

Oh dang, you're right I misunderstood. Yes, adding a "module" entrypoint is the only requirement, but you're right that it would be good to add a guide that makes the steps needed more explicit. Thanks for the feedback!

@FredKSchott
Copy link
Owner

Added some "learn more..." text that should point package authors in the right direction

@karlhorky
Copy link
Author

Cool thanks, super helpful! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants