Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model is only saved when an evalFunc is passed #2

Open
etiennedi opened this issue May 9, 2021 · 0 comments
Open

Model is only saved when an evalFunc is passed #2

etiennedi opened this issue May 9, 2021 · 0 comments

Comments

@etiennedi
Copy link

etiennedi commented May 9, 2021 •
edited

First of all, thank you for open-sourcing the training scripts. This looks very promising for semantic search and I'm currently evaluating some use-cases.

Something I noticed while playing around with it:

If no evalFunc is passed, we never make it to the branch of the code that calls .save_pretrained().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@etiennedi