Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button for empty-commits #1028

Closed
ylecuyer opened this issue Jan 28, 2018 · 5 comments · Fixed by #1030
Closed

Add button for empty-commits #1028

ylecuyer opened this issue Jan 28, 2018 · 5 comments · Fixed by #1030

Comments

@ylecuyer
Copy link
Contributor

Useful for triggering CI

@campersau
Copy link
Collaborator

You can amend the previous commit with no additional changes from the UI.

@ylecuyer
Copy link
Contributor Author

ylecuyer commented Jan 28, 2018

Yes but it is not an empty commit, it forces you to ff push, an empty commit doesn't

@jung-kim
Copy link
Collaborator

Isn't ability to re trigger CI should be a fix in CI side not the git source side?

@ylecuyer
Copy link
Contributor Author

Well it's a git command so I expect to have it available in my git client.

(fwiw with the CI we are currently using (drone) if you restart the CI while a build is running, it's not possible to cancel/restart the build from the interface. You must create a new commit to newly trigger the CI)

@jung-kim
Copy link
Collaborator

I understand the problem but I feel like that should be the fixes on drone side not ungit

I think empty commit is fine but I hope it doesn't bring too much complications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants