%U is null when launchBrowser is false and launchCommand is set

[cgty]

I used to use the following .ungitrc to start ungit server and launch chromium without the browser toolbars.

{
  "debug": true,
  "launchCommand": "chromium-browser --app=%U",
  "launchBrowser": false
}

It was working in the previous versions of ungit (I can't recall the exact version I used before).

With the latest version, when I run ungit within a git repository, the output is as follows:

## Ungit started ##

Took 635ms to start server.
Running custom launch command: chromium-browser --app=null

And an empty chromium window (with toolbars) is launched.

If I set launchBrowser to true, %U is correctly set and chromium is launched with the correct configuration. But the default browser is also launched -as expected-, which makes it an unusable workaround.

I think adding || config.launchCommand to this line might fix this issue, but I haven't tested it myself.

ungit/bin/ungit

Line 32 in b864529

} else if (override || config.launchBrowser) {

I can test & verify it locally and send a PR if my approach is right.

versions
ungit: 1.4.13
node: v8.9.4
npm: 5.6.0
os: linux

[ylecuyer]

👍