Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"$ is not defined" when clicking magnifying glass #1086

Closed
StevenGBrown opened this issue May 5, 2018 · 2 comments · Fixed by #1087
Closed

"$ is not defined" when clicking magnifying glass #1086

StevenGBrown opened this issue May 5, 2018 · 2 comments · Fixed by #1087

Comments

@StevenGBrown
Copy link

StevenGBrown commented May 5, 2018

Click on the magnifying glass to the right of a branch name:
screen shot 2018-05-05 at 3 33 54 pm

An error message is displayed:
screen shot 2018-05-05 at 3 35 53 pm

This appears in the browser console:

Uncaught ReferenceError: $ is not defined
    at GitNodeViewModel.showRefSearchForm (git-node.js:166)
    at HTMLButtonElement.<anonymous> (knockout:99)
    at HTMLButtonElement.dispatch (jquery:5183)
    at HTMLButtonElement.elemData.handle (jquery:4991)
    at HTMLButtonElement.d (raven.js:438)

No errors displayed in the CLI output.

Can reproduce with:

  • Version 1.4.21 installed with npm and
  • 671dd02, started with instructions on CONTRIBUTING page.

Environment:

  • node 9.4.0
  • npm 6.0.0
  • macOS High Sierra
@campersau
Copy link
Collaborator

Yes a require('jquery') is missing and jquery ui is not correctly setup because each widget must be required individually.

I can provide a fix in the next few hours.

@StevenGBrown
Copy link
Author

The error is no longer displayed and I'm looking forward to spending more time with ungit.

Thank you @campersau, @jung-kim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants