Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ungit don't detect that a tag was pushed on the remote #1139

Closed
gigi206 opened this issue Sep 15, 2018 · 10 comments · Fixed by #1144
Closed

Ungit don't detect that a tag was pushed on the remote #1139

gigi206 opened this issue Sep 15, 2018 · 10 comments · Fixed by #1144
Assignees

Comments

@gigi206
Copy link
Contributor

gigi206 commented Sep 15, 2018

Git tag v1.0.0 and v1.1.0 are pushed on the remote, but only tag v1.0.0 is detected on the remote.

If I click on tag v1.1.0 ungit displays the push button.

I have already tried to erase the tag v1.1.0 from github and click push again with ungit but this is the same result.

$ git ls-remote --tags
From https://github.com/xxx/xxx.git
aeab362abe50f5e9ad8cf98b79e7cc522d2e8c97        refs/tags/v1.0.0
f6191bf1b622266a6928d667550f5c3a518357ad        refs/tags/v1.0.0^{}
3db2b40a60395c1944957fd3d345f2d2dbeb8dce        refs/tags/v1.1.0

Ungit see only one pushed :

@jung-kim
Copy link
Collaborator

Is that your ungit? https://github.com/xxx/xxx.git

Because https://github.com/FredrikNoren/ungit/tags doesn't show v1.1.0 and I don't think it was ever published.

I think the wrong remote is targeted when you try to push the tag. When you push tag or branches, make sure correct remote is targeted in the remote section.

This is a bit confusing part of the current UI and please let me know if you have any suggestions.

@gigi206
Copy link
Contributor Author

gigi206 commented Sep 16, 2018

Sorry if my explications are confused.

I will try to explain better.

I replace the true url with xxx but the remote exists. The configured remote is :

$ git remote show origin
* remote origin
  Fetch URL: https://github.com/gigi206/VSCode-Anywhere.git
  Push  URL: https://github.com/gigi206/VSCode-Anywhere.git
  HEAD branch: master
  Remote branches:
    dev    tracked
    master tracked
    old    tracked
  Local branches configured for 'git pull':
    dev    merges with remote dev
    master merges with remote master
  Local refs configured for 'git push':
    dev    pushes to dev    (local out of date)
    master pushes to master (up to date)

We can see on previous images that the tag v1.1.0 is only detected locally by ungit. And the tag v1.0.0 is detected on the remote and locally by ungit. But we can see that tag v1.1.0 exists on the remote :

$ git ls-remote --tags
From https://github.com/gigi206/VSCode-Anywhere.git
aeab362abe50f5e9ad8cf98b79e7cc522d2e8c97    refs/tags/v1.0.0
f6191bf1b622266a6928d667550f5c3a518357ad    refs/tags/v1.0.0^{}
3db2b40a60395c1944957fd3d345f2d2dbeb8dce    refs/tags/v1.1.0

Ungit does not detect tag v1.1.0 on the remote. Ungit show only the local tag :

@jung-kim jung-kim self-assigned this Oct 1, 2018
@jung-kim
Copy link
Collaborator

jung-kim commented Oct 1, 2018

You are asking why there is no remote v1.1.0 tag right?

when you do git ls-remote --tags is refs/tags/v1.1.0^{} tag exists?

@gigi206
Copy link
Contributor Author

gigi206 commented Oct 2, 2018

You are asking why there is no remote v1.1.0 tag right?

Yes

when you do git ls-remote --tags is refs/tags/v1.1.0^{} tag exists?

refs/tags/v1.1.0^{} not exist

@jung-kim
Copy link
Collaborator

jung-kim commented Oct 4, 2018

https://github.com/FredrikNoren/ungit/blob/master/components/graph/graph.js#L290

Ungit does look for that ^{} tag and treat that as remote ref. It is very strange that that is not happening here and I'm not aware of how a remote tag can be created such way as this is an exception I didn't think was possible.

Was creation of this remote tag some how different than normal?

@gigi206
Copy link
Contributor Author

gigi206 commented Oct 4, 2018

Was creation of this remote tag some how different than normal?

No I push the tag with Ungit. I have already try to delete and create the same tag but I have the same issue.

@jung-kim
Copy link
Collaborator

jung-kim commented Oct 7, 2018

#1144 is created to fix this issue.

What version of git are you running on? I think newer version of git changed how the remote tag refs are working and this is confusing the heck out of me.

@gigi206
Copy link
Contributor Author

gigi206 commented Oct 8, 2018

Thank you for the fix 👍
Actually I use git version 2.19.1 but when I test I think I used 2.19.0 or perhaps 2.18.0.

I will test when @Hirse will update the VSCode extension.

@Hirse
Copy link
Contributor

Hirse commented Oct 9, 2018

@gigi206, I have updated the extension.

@gigi206
Copy link
Contributor Author

gigi206 commented Oct 9, 2018

It works, thank you to both of you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants