Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff out is not properly escaping #1387

Closed
bes-internal opened this issue Jun 22, 2020 · 2 comments · Fixed by #1385
Closed

diff out is not properly escaping #1387

bes-internal opened this issue Jun 22, 2020 · 2 comments · Fixed by #1385

Comments

@bes-internal
Copy link
Contributor

Sometimes diff pane is suffering from properly html (to say user input) escaping:

Screenshot_4

real diff
Screenshot_3

ungit v1.5.7
@campersau campersau mentioned this issue Jun 28, 2020
Closed
@campersau
Copy link
Collaborator

Thanks for the report. It seems to be a bug with diff2html so I opened rtfpessoa/diff2html#324

@campersau
Copy link
Collaborator

Fixed by #1385

@campersau campersau linked a pull request Jul 1, 2020 that will close this issue
Bump Dependencies #1385
Merged
@campersau campersau mentioned this issue Jul 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Dependencies FredrikNoren/ungit
2 participants
@bes-internal @campersau