Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maxConcurrentGitOperations #707

Merged

Conversation

bakkerthehacker
Copy link
Contributor

Somewhere in the move to a promise based git system, ungit stopped using this config option.

This changes adds the maxConcurrentGitOperations option back. This change is quite important to me as several repositories only work well with maxConcurrentGitOperations = 1. Without it, ungit complains about index.lock files

@jung-kim
Copy link
Collaborator

I like the thought but why are we bringing in async lib? There is no need for this.

I see, async lib is parallelizing calls... Hmm... I'd rather solve this problem with bluebird. And isn't this only a problem if multi git process are running on a same git repo?

@jung-kim
Copy link
Collaborator

jung-kim commented Mar 5, 2016

Merging as there is no clear and easy alternate way to do this in bluebird. Although there are some other bluebird plugins we could use it hardly seems worth it.

jung-kim added a commit that referenced this pull request Mar 5, 2016
@jung-kim jung-kim merged commit 4b3c154 into FredrikNoren:master Mar 5, 2016
@bakkerthehacker bakkerthehacker deleted the concurrent_git_operations branch March 28, 2016 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants