viewing a commit's file changes is broken

[dbkaplun]

When I click on a previous commit bubble, I am able to see a list of files that were changed as well as the number of lines changed in each file. However, when I click on a file, I am unable to see the actual changes made to that file, although I can see the UI twitch on click and Event: Object {event: "graph-render"} appears in the JS console.

ungit@0.10.1

[waldyrious]

Same here.

[lfx]

Using ungit@0.10.1, can't reproduce.

@dbkaplun, @waldyrious have you updated ungit recently?

[jung-kim]

I cannot reproduce this but if this is a pretty big bug.

Could you share client log, server log and the file name, and sha1 of diff you are trying to see?

[waldyrious]

This apparently only happens if I run ungit from a subdirectory of the repo, rather than its root. HTH :)

[campersau]

Ah, so I can reproduce it too.

The problem is that if you are in a subdirectory the filename is always relatative to the git directory but git diff wants an relative path from the executing directory.

For example if you are in the subdirectory components of the ungit project the git diff command looks like this: ungit/components> git diff a49c657cfa1bab61d740cf1fc3a72c5f15b2ed26^ a49c657cfa1bab61d740cf1fc3a72c5f15b2ed26 -- clicktests/test.generic.js
But it should have been this: ungit/components> git diff a49c657cfa1bab61d740cf1fc3a72c5f15b2ed26^ a49c657cfa1bab61d740cf1fc3a72c5f15b2ed26 -- ../clicktests/test.generic.js

(Notice the ../ in the filename.)

[jung-kim]

Yup, I will be closing #706 in lieu of this ticket.

I think this would be a great time to start using absolute path within ungit

[dbkaplun]

I run ungit as a daemon, as outlined here (with a few insignificant modifications): https://github.com/FredrikNoren/ungit/wiki/Startup-Script-for-Mac-OS-X. If this is intended usage, ungit should not rely on the cwd at all in that case.

[jung-kim]

@dbkaplun This now works for me and master branch should work for you but please feel free to reopen if this is still a problem.

[dbkaplun]

Works now, thanks @codingtwinky!