Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering path results in error #861

Closed
normenmueller opened this issue Feb 7, 2017 · 8 comments · Fixed by #862
Closed

Entering path results in error #861

normenmueller opened this issue Feb 7, 2017 · 8 comments · Fixed by #862

Comments

@normenmueller
Copy link

After upgrading to v1.1.5, I get the following error:

  1. First I launch ungit just as normal
  2. Ungit web page opens, initialized with my home dir /Users/nrm
  3. Trying to append a / results in an error, e.g., /Users/nrm/

Whooops
Something went wrong, reload the page to start over.

Any ideas?

@campersau
Copy link
Collaborator

Yes, we missed this during promisification in #852

It should be server.getPromise instead of server.get.

cc @codingtwinky

@normenmueller
Copy link
Author

Ah. OK. Thanks.

Will you a release a fixed version, e.g., v1.1.6?

@jung-kim
Copy link
Collaborator

jung-kim commented Feb 7, 2017

Ahh poopsicles... didn't do .get( global search on the source folder...

Thanks @campersau

@normenmueller
Copy link
Author

How can I get this fix?

@jung-kim
Copy link
Collaborator

jung-kim commented Feb 8, 2017

Sorry! getting used to this new deploy and forgot to bump the version in package.json. it is now merged and I think it should cut new npm package soon. Sorry about that... I've been sloppy lately...

cc: @FredrikNoren

@jung-kim jung-kim reopened this Feb 8, 2017
@jung-kim
Copy link
Collaborator

jung-kim commented Feb 8, 2017

@FredrikNoren Hmm, CD is not triggering with this PR #863. Am I missing something else?

@jung-kim
Copy link
Collaborator

jung-kim commented Feb 8, 2017

Ah nvm, it was triggered and ungit@1.1.6 is cut now. I should have waited more... :P

https://www.npmjs.com/package/ungit

@jung-kim
Copy link
Collaborator

Will be closing this issue now, please let me know if you see any other problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants