Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update to core22 to use the kde-neon extension #86

Closed
ScarlettGatelyMoore opened this issue Jun 1, 2023 · 24 comments
Closed

Please update to core22 to use the kde-neon extension #86

ScarlettGatelyMoore opened this issue Jun 1, 2023 · 24 comments

Comments

@ScarlettGatelyMoore
Copy link
Contributor

Core20 is no longer supported for the kde-neon extension as we have no way to security updates. I am more than happy to help here.
Thanks,
Scarlett

@luzpaz
Copy link
Collaborator

luzpaz commented Jun 1, 2023

Thank you for the offer! We will take you up on it!

@ScarlettGatelyMoore
Copy link
Contributor Author

Ok, forking and will do a PR

@luzpaz
Copy link
Collaborator

luzpaz commented Jun 7, 2023

bump

@ScarlettGatelyMoore
Copy link
Contributor Author

Sorry, slight delay while I wait for a PR to get merged in snapcraft. Still on my TO-DO!

@luzpaz
Copy link
Collaborator

luzpaz commented Jun 7, 2023

TIA, really appreciate any help with this!

@chennes
Copy link
Member

chennes commented Aug 5, 2023

I'm in the process of trying to get freecad-deps updated to core22, I am assuming that is a prerequisite for updating this one to core22 as well?

@luzpaz
Copy link
Collaborator

luzpaz commented Aug 5, 2023

Ping @ScarlettGatelyMoore

@ScarlettGatelyMoore
Copy link
Contributor Author

I'm in the process of trying to get freecad-deps updated to core22, I am assuming that is a prerequisite for updating this one to core22 as well?

Yes I imagine it is. Please let me know if you need help or finish it and I will get this done. The PR I was waiting for has finally gone through.

@chennes
Copy link
Member

chennes commented Aug 7, 2023

@ScarlettGatelyMoore I was hoping it was just a matter of switching core20 to core22 in that repo (it's pretty simple otherwise), but the build timed out on the runner after six hours. So I tried building it locally and I get a strange missing library failure when building OCCT (the library is present where I expect it when examining the failure with snapcraft --debug. If you've got time to look into switching FreeCAD-deps-snap (the core22 branch) to core22 I'd appreciate any help you can provide.

@ScarlettGatelyMoore
Copy link
Contributor Author

Sure thing, will take a look now

@malix0
Copy link

malix0 commented Aug 7, 2023

Hi, I'm waiting for FreeCAD 0.21 snap release, if I can help in some way, I'll try to do my best

@ScarlettGatelyMoore
Copy link
Contributor Author

@ScarlettGatelyMoore I was hoping it was just a matter of switching core20 to core22 in that repo (it's pretty simple otherwise), but the build timed out on the runner after six hours. So I tried building it locally and I get a strange missing library failure when building OCCT (the library is present where I expect it when examining the failure with snapcraft --debug. If you've got time to look into switching FreeCAD-deps-snap (the core22 branch) to core22 I'd appreciate any help you can provide.

Here is my PR FreeCAD/freecad-deps-snap#2

The only thing that fails for me is the version part, so it is commented.

@chennes
Copy link
Member

chennes commented Aug 7, 2023

Hi, I'm waiting for FreeCAD 0.21 snap release, if I can help in some way, I'll try to do my best

The 0.21 snap is released, you should have access to it in the stable channel.

@chennes
Copy link
Member

chennes commented Aug 8, 2023

Here is my PR FreeCAD/freecad-deps-snap#2

OK, it took me a few tries, but I've now got those core22 deps installed as a private snap package. So the next step is to upgrade this one to core22, along with whatever other library dependencies that entails. Do you have time to look at that, @ScarlettGatelyMoore ?

@ScarlettGatelyMoore
Copy link
Contributor Author

Hi,
A quick look and it looks like the
build-snaps:
- freecad-deps-core20
stage-snaps:
- freecad-deps-core20

Needs fixing in the snap store first. Do you have the powers to upload that private freecad-deps-core22 snap we just worked on to the store and make it public? This snap depends on it and won't build without it.

@ScarlettGatelyMoore
Copy link
Contributor Author

master...ScarlettGatelyMoore:FreeCAD-snap:master
Is what I have so far, I can't test it until freecad-deps-snap is updated in the snap store.

@chennes
Copy link
Member

chennes commented Aug 9, 2023

Sorry, I didn't see that I could switch to "unlisted" from "private", but only after I created the snap. That's done now, you should be able to access freecad-deps-core22

@ScarlettGatelyMoore
Copy link
Contributor Author

Great! I should be able to wrap this up and do a PR tomorrow.

@ScarlettGatelyMoore
Copy link
Contributor Author

Here you go:
#92

@chennes
Copy link
Member

chennes commented Aug 11, 2023

Can you take a look at the error in this Actions run? I don't know why it's failing... https://github.com/FreeCAD/FreeCAD-snap/actions/runs/5827731613/job/15804251434

@ScarlettGatelyMoore
Copy link
Contributor Author

Can you take a look at the error in this Actions run? I don't know why it's failing... https://github.com/FreeCAD/FreeCAD-snap/actions/runs/5827731613/job/15804251434

Apologies, I was working in the snap directory, I have fixed it now with the full path and should fix the error

@ScarlettGatelyMoore
Copy link
Contributor Author

#93

@chennes
Copy link
Member

chennes commented Aug 11, 2023

This is working now, thanks for the assist @ScarlettGatelyMoore !!

@chennes chennes closed this as completed Aug 11, 2023
@luzpaz
Copy link
Collaborator

luzpaz commented Aug 12, 2023

Indeed, thank you very much @ScarlettGatelyMoore !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants