Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Assembly] Icons for joints #10662

Closed
2 tasks done
PaddleStroke opened this issue Sep 12, 2023 · 25 comments
Closed
2 tasks done

[Assembly] Icons for joints #10662

PaddleStroke opened this issue Sep 12, 2023 · 25 comments
Labels
WB Assembly Related to the Integrated Assembly Workbench

Comments

@PaddleStroke
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

We need some good icons in-line with freecad style to cover the different types of joints :

Fixed Joint
Revolute Joint
Cylindrical Joint
Slider Joint
Ball Joint
Parallel Joint
Coplanar Joint
Tangent Joint

Anyone with skills wants to jump in?

Draft PR on joints : #10611

Full version info

0.22

Subproject(s) affected?

Other (specify in description)

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@qewer33
Copy link
Contributor

qewer33 commented Sep 12, 2023

It would be great have some sort of "visual examples" of these joints to replicate in the icon style

@luzpaz luzpaz added the WB Assembly Related to the Integrated Assembly Workbench label Sep 12, 2023
@qewer33
Copy link
Contributor

qewer33 commented Sep 12, 2023

I've started working on these with inspiration taken from OnShape's icons. These aren't the exact ideal icons for each constraint but more like proof of concepts. Let me know how they look:

image

The idea is to have a "base" object (a cylinder in this case) and then red sketcher-like "constraint" icons on top of it. The base object could be changed to anything (a Part container icon or a cube are also good candidates) but I personally think a cylinder looks good.

Here is OnShape's icons:

image

@onekk
Copy link

onekk commented Sep 12, 2023

Maybe this could be a decent overview, of different incarnations, as mimicking other software should not be encouraged, as it could incurr in copyright infringiments if they are "too similar".

https://blog.3dcs.com/cad-joints-and-constraints-how-to-use-catia-nx-and-creo-joints-and-constraints-tolerance-analysis

Maybe simply changing the shape, as example using an exagon instead of a cylinder should make enough differences to not recall immediatly the "inspiration icons".

IMHO as usual.

Regards

Carlo D.

@kadet1090
Copy link
Contributor

image

For the Slider icon I'd personally put arrows under the cylinder in isometric view, as in most cases this join in case of cylindrical object will be applied to base of the cylinder.

@PaddleStroke
Copy link
Contributor Author

Note slider is up-down along one axis. So the double arrows would rather be for coplanar.
Also fixed, I think there might be an ambiguity here as we will have 2 kind of fixed.

  • The first one is going to be a 'fix part' that will lock a part in place.
  • Then there is what I called 'Fixed Joint' that is a joint between 2 parts that leaves no DOF. So it fixes two parts together.

That's maybe why onshape is using the term 'fastened' for this joint.

@qewer33
Copy link
Contributor

qewer33 commented Sep 12, 2023

Here's what I got currently:

image

I have no idea what to do for cylinder joint as that just seems to be revolute but with slide motion, maybe same as revolute but with an up-down arrow?

@qewer33
Copy link
Contributor

qewer33 commented Sep 12, 2023

Also fixed, I think there might be an ambiguity here as we will have 2 kind of fixed.

* The first one is going to be a 'fix part' that will lock a part in place.

* Then there is what I called 'Fixed Joint' that is a joint between 2 parts that leaves no DOF. So it fixes two parts together.

That's maybe why onshape is using the term 'fastened' for this joint.

I don't think "fastened" is that great of a name for a joint like this either but yeah fixed might only imply fixing a part in place in 3D space, like how other Assembly WBs (Asm3 and A2+) work.

@qewer33
Copy link
Contributor

qewer33 commented Sep 12, 2023

For the Slider icon I'd personally put arrows under the cylinder in isometric view, as in most cases this join in case of cylindrical object will be applied to base of the cylinder.

I'm not sure I understand, can you elaborate?

@kadet1090
Copy link
Contributor

For the Slider icon I'd personally put arrows under the cylinder in isometric view, as in most cases this join in case of cylindrical object will be applied to base of the cylinder.

I'm not sure I understand, can you elaborate?

Nvm, I thought that this is icon for Planar joint, now everything is clear!

@qewer33
Copy link
Contributor

qewer33 commented Sep 12, 2023

Last iteration (still not happy with Cylindrical though):

image

@PaddleStroke zip file: zJoint_Icons.zip

3D-ish icons similar to ones in the link sent by @onekk might also look nice but I don't have the time to create those, would be good to see someone else trying that idea out.

@qewer33
Copy link
Contributor

qewer33 commented Sep 12, 2023

Made an alternate set with tweaks:

image

Files: zJoint_Icons_Alt.zip

@tobiasfalk
Copy link
Contributor

I like the alternative version, but I would make the blue cylinder also look out on the bottom. So that the yellow one is more of a ring on a cylinder. This goes for slide, revolt and cylindrical joint.

@qewer33
Copy link
Contributor

qewer33 commented Sep 13, 2023

I like the alternative version, but I would make the blue cylinder also look out on the bottom. So that the yellow one is more of a ring on a cylinder. This goes for slide, revolt and cylindrical joint.

Good idea, here's how they look:

image

Files: zJoint_Icons_Alt.zip

@PaddleStroke
Copy link
Contributor Author

PaddleStroke commented Sep 13, 2023

Haha damn I was just doing that ! Didn't thought you'd be up so early doing icons :)
image
Here I offer alternate very similar to the one you just posted.
3 small differences :

  • I removed the red lines of the slider / cylindrical. I think they don't bring much and clutter the icon.
  • The arrows are a tiny bit more curved.
  • The ring is a bit wider
    Files : Joint_Revolute_Alt.zip

@qewer33
Copy link
Contributor

qewer33 commented Sep 13, 2023

Haha damn I was just doing that ! Didn't thought you'd be up so early doing icons :)

I had a little free-time in my hands so I thought I'd fill it up 😄

* I removed the red lines of the slider / cylindrical. I think they don't bring much and clutter the icon.

* The arrows are a tiny bit more curved.

* The ring is a bit wider

Yours look better. And on second thought, I agree that the red parallel lines are better removed.

@qewer33
Copy link
Contributor

qewer33 commented Sep 13, 2023

@PaddleStroke I've rotated and adjusted them to give an isometric 3D effect as an experiment:

image

Files: Joint_Revolute_Alt.zip

@PaddleStroke
Copy link
Contributor Author

I like those !
Few last remarks :

  • Ball : It doesn't look much like a ball. I think the arrows are a bit too thick, and curving them a little bit more would look better. (so that the center of the arrows would be further away from the ball center)
  • Tangent, rather than a blue line we could use a blue cylinder. And perhaps an isometric view too.

@tobiasfalk
Copy link
Contributor

tobiasfalk commented Sep 13, 2023

@PaddleStroke I've rotated and adjusted them to give an isometric 3D effect as an experiment:

image

Files: Joint_Revolute_Alt.zip

In Cylindrical, I would put the red arrow for sliding g on top of the ring and not below. This way it is more visible.

@qewer33
Copy link
Contributor

qewer33 commented Sep 13, 2023

* Tangent, rather than a blue line we could use a blue cylinder. And perhaps an isometric view too.

Something like this seems to look better (although I'm not sure about the arrows), also updated the ball and cylinder:

image

Files: zJoint_Icons_Alt.zip

@PaddleStroke
Copy link
Contributor Author

PaddleStroke commented Sep 13, 2023

@qewer33 do you want to open a PR to introduce those icons ?
If so please rename them to follwo the proper naming convention. See the assembly.qrc with the names :

<RCC>
    <qresource prefix="/">
        <file>icons/Assembly_InsertLink.svg</file>
        <file>icons/preferences-assembly.svg</file>
        <file>panels/TaskAssemblyInsertLink.ui</file>
        <file>preferences/Assembly.ui</file>
        <file>icons/Assembly_CreateJointBall.svg</file>
        <file>icons/Assembly_CreateJointCylindrical.svg</file>
        <file>icons/Assembly_CreateJointFixed.svg</file>
        <file>icons/Assembly_CreateJointParallel.svg</file>
        <file>icons/Assembly_CreateJointPlanar.svg</file>
        <file>icons/Assembly_CreateJointRevolute.svg</file>
        <file>icons/Assembly_CreateJointSlider.svg</file>
        <file>icons/Assembly_CreateJointTangent.svg</file>
    </qresource>
</RCC>

If not I'll add them to my current PR.

@qewer33
Copy link
Contributor

qewer33 commented Sep 13, 2023

@qewer33 do you want to open a PR to introduce those icons ? If so please rename them to follwo the proper naming convention. See the assembly.qrc with the names :

Sure, I can. I need to add them to Mod/Assembly/Gui/Resources/icons like in your draft PR right?

@PaddleStroke
Copy link
Contributor Author

Yes that's it

@qewer33
Copy link
Contributor

qewer33 commented Sep 13, 2023

@PaddleStroke PR opened. Also you can mention me on the forum or Discord server if/when there are more icon needs for the Assembly WB. Would be glad to help!

@MisterMakerNL
Copy link
Contributor

MisterMakerNL commented Sep 20, 2023

Icons look awesome! well done!

@maxwxyz
Copy link
Collaborator

maxwxyz commented Sep 27, 2023

I really like the new icons. Why do we need a separate joint for the combination of slider and revolute (=cylindrical)?
These icons are very similar as well. Would it be possible to make the sliding icon a sliding box or rectangle which is already visually not possible to rotate? Currently all three icons are cylinders.
For tangent I would prefer a plane on a cylinder or ball. Based on the icons I do not understand the difference between tangent and ball joint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB Assembly Related to the Integrated Assembly Workbench
Projects
Development

No branches or pull requests

9 participants