Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Optimize included png and svg files #12416

Open
2 tasks done
rmeissn opened this issue Feb 15, 2024 · 5 comments
Open
2 tasks done

Enhancement: Optimize included png and svg files #12416

rmeissn opened this issue Feb 15, 2024 · 5 comments
Labels
Feature FR for improvements or new features UI/UX

Comments

@rmeissn
Copy link

rmeissn commented Feb 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

When heading through my local filesystem with image optimization tools (for svg, png and jpg files), I noticed that some freecad related files were optimized.

Thus I've downloaded the current source code and executed those programs within the folder.
Results:

  • SVG files are compressible by about 40-90% with svgo -r -f ./FreeCAD-main --multipass
  • PNG files are compressible by about 3-30% with oxipng -o max -r -p ./FreeCAD-main

Possibly apply those programs and optimizations to your image files to save some space, reduce download sizes and necessary computing power to display the images - even though all of these are just minimal improvements.

Full version info

None

Subproject(s) affected?

None

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz
Copy link
Collaborator

maxwxyz commented Feb 15, 2024

@obelisk79 what do you think about this?

@maxwxyz maxwxyz added UI/UX Feature FR for improvements or new features labels Feb 15, 2024
@xtemp09
Copy link
Contributor

xtemp09 commented Feb 15, 2024

@rmeissn, how much space have you saved?

@rmeissn
Copy link
Author

rmeissn commented Feb 15, 2024

For the current source-code (downloaded as a zip and extracted, according to du):
Current size: 373 200 KB
Optimized Size: 356 704 KB

But it might be best to optimize these files after the build step, as e.g. svgo is removing data that is unnecessary for display, but might be valuable for further development.

@luzpaz
Copy link
Contributor

luzpaz commented Mar 20, 2024

Any decisions on this ?

@obelisk79
Copy link
Contributor

I didn't think anything ever came out of this. I commend the efforts to optimize the images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature FR for improvements or new features UI/UX
Projects
None yet
Development

No branches or pull requests

5 participants