Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Cancelling Sketcher B-spline creation tools leaves behind construction geometry #12473

Open
2 tasks done
Roy-043 opened this issue Feb 17, 2024 · 2 comments
Open
2 tasks done
Labels
Bug This issue or PR is related to a bug WB Sketcher Related to the Sketcher Workbench

Comments

@Roy-043
Copy link
Contributor

Roy-043 commented Feb 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

If any of the 4 Sketcher B-spline creation tools is cancelled by starting another tool after points have been picked, contruction geometry is left behind.

  1. Start Sketcher_CreatePeriodicBSplineByInterpolation.
  2. Pick several points.
  3. Start Sketcher_CreateLine.
  4. Only one point from the spline is visible.
  5. Pick two points for the line.
  6. The other points of the spline also become visible.

Full version info

OS: Windows 8 build 9600
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.35994 (Git)
Build type: Release
Branch: main
Hash: 69097667df47b2cc86d8688d2dbb545319e33e68
Python 3.10.13, Qt 5.15.8, Coin 4.0.2, Vtk 9.2.6, OCC 7.6.3
Locale: C/Default (C) [ OS: Dutch/Netherlands (nl_NL) ]
Installed mods:

Subproject(s) affected?

Sketcher

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz maxwxyz added Bug This issue or PR is related to a bug WB Sketcher Related to the Sketcher Workbench labels Feb 17, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Feb 17, 2024

can confirm.
@AjinkyaDahale

@wwmayer
Copy link
Contributor

wwmayer commented Mar 16, 2024

It looks like there is a mess with the transactions when creating the spline. After clicking the first point a transaction "Add Knot Point" is added to the Undo list. When finishing it then this transaction is committed.

The behaviour of most other commands is different: they add a transaction after finishing the creation of the geometry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This issue or PR is related to a bug WB Sketcher Related to the Sketcher Workbench
Projects
None yet
Development

No branches or pull requests

3 participants