Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The context-menu of the tree view is too overloaded #13194

Open
2 tasks done
wwmayer opened this issue Mar 28, 2024 · 7 comments
Open
2 tasks done

The context-menu of the tree view is too overloaded #13194

wwmayer opened this issue Mar 28, 2024 · 7 comments
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD DWG Input or discussion from Design Working Group needed Feature FR for improvements or new features UI/UX

Comments

@wwmayer
Copy link
Contributor

wwmayer commented Mar 28, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

For a selected object the context-menu of the tree view contains too many commands. The issue was brought up here

E.g, for a selected part object it currently contains 28 top-level commands plus extra commands of some sub-menus.
Tree-contextmenu

A context-menu should only contain commands that relate to the selected object and not any unrelated commands. And it should only contain the more important commands while for less important commands it's sufficient to access them via the menu bar.

  • From the context-menu shown above I would remove the commands: Cut, Copy, Paste and Properties
  • Tree settings should only be shown if nothing is selected as this only relates to the tree view
  • The commands Show selection, Hide selection and Toggle selectability are at least questionable

Full version info

OS: Ubuntu 22.04.4 LTS (XFCE/xubuntu)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.36642 (Git)
Build type: debug
Branch: main
Hash: 1eea88a8b72f3104e3756474d4c3df8c22a6e0f9
Python 3.10.12, Qt 5.15.3, Coin 4.0.0, Vtk 7.1.1, OCC 7.5.1
Locale: German/Germany (de_DE)

Subproject(s) affected?

None

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz
Copy link
Collaborator

maxwxyz commented Mar 28, 2024

related: #12826

@X-Ryl669
Copy link

X-Ryl669 commented Mar 28, 2024

In this menu, you have 5 toggle commands, many of them are redundant (like visibility) and incompatible or logically impossible (once an item is invisible, you can't select it because it doesn't exist as an visual object anymore). Why not a check-able icons then in a unique top row?

Some are clearly useless in a menu (like "Toggle transparency" which could be done in the Appearance dialog, or to avoid opening a dialog, in a submenu).

Why is "Set color" not in the "Appearance" section ?
What is the use of "Random color" ? Has anyone used that in the last month, last year ? Are we playing a game here?

Also, there's the Fitz Law issue, the most used command should be as close as possible to the cursor. With the upcoming toponaming feature, you're more likely to select "Recompute". It must be first or in the first items.

A circular menu (like FormIt, or Fusion360) is more convenient to use and you can group related items in submenu for "advanced" settings. If it's not possible to make a circular menu, then an "context toolbar" menu (à la Solidworks, where only icons are show on a toolbar that appears close to your right clicked cursor) also solves Fitz Law problem.

However, an icon only solution works if the icons are different enough. I know I won't make friend criticizing one of the biggest issue in FreeCAD: the exponential icons problem that are unkillable. Every workspace brings in its numerous icons in the toolbars, making them unusable, hard to spot, and sometimes, most of the time, useless.

@maxwxyz maxwxyz added Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD UI/UX Feature FR for improvements or new features labels Mar 28, 2024
@wwmayer
Copy link
Contributor Author

wwmayer commented Mar 28, 2024

Why is "Set color" not in the "Appearance" section ?

This is part of the Part wb while the others are from the core system and added afterwards. So, will be quite difficult to change the order.

What is the use of "Random color" ? Has anyone used that in the last month, last year ? Are we playing a game here?

I used it recently. But yes it can be removed from the context-menu as it's too much of a niche function.

With the upcoming toponaming feature, you're more likely to select "Recompute". It must be first or in the first items.

The top position must always be reserved for the most suitable command that you trigger with a double click. The text of the command is bold.

@X-Ryl669
Copy link

X-Ryl669 commented Mar 28, 2024

This is part of the Part wb while the others are from the core system and added afterwards. So, will be quite difficult to change the order.

Why ?

The top position must always be reserved for the most suitable command that you trigger with a double click. The text of the command is bold.

Why ?

I'm not trying to troll here. Nor can I be exhaustive with all the menu issues. I'm just a user that used to work with different CAD suites and I find FreeCAD to be subpar with all the other software. Not in the feature set, but in the UX mainly.

Other CAD software don't have the "default double click action" takes one menu row (because, well, it's useless one since one can double click). They don't care about what order the items were added in the menu and they don't have 1 thousand choices in the menu. If you need so many choices, just select the item and use the global menu bar. It's actually easier to select an action in the global menu bar than in such a giant context menu (simply because you'll quickly move your cursor up to the top of the screen, the cursor will stop on top of the screen anyway, you don't have to be precise) and then you can select your action. A context menu requires precise pointing, and, in some case, scrolling.

I think the menu should go through some kind of runtime filter to remove items or reorder them if it can't be done at design time. Its current state is anarchic and it's becoming worse with #12994. Ideally, the menu shouldn't be displayed like it is.

Maybe adding a statistic collector for some release versions to collect usage statistic for each menu selection (sorted by current active workbench, current active item) and then remove (or move to some submenu) the unused items.

I've seen they are some work on trying to remove the pesky report window to have something more usable from a user perspective, but the menus and toolbars and shortcuts need the same love if not more.

@X-Ryl669
Copy link

For reference here are the other context menu in other CAD suite:
Solidworks (with a context icon box with most used actions):
image
image

Fusion360 (circular menu and context menu):
image

Formit (circular menu):
image

Blender (circular menu, notice the consistent shortcuts):
image
And all its possible context menu:
image

@marcin86junior
Copy link

Maybe new sub-menu:

Bez tytułu

@wwmayer
Copy link
Contributor Author

wwmayer commented Apr 14, 2024

@maxwxyz maxwxyz added the DWG Input or discussion from Design Working Group needed label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD DWG Input or discussion from Design Working Group needed Feature FR for improvements or new features UI/UX
Projects
None yet
Development

No branches or pull requests

4 participants