Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketcher: indication that lines are overlapping #13381

Open
2 tasks done
FEA-eng opened this issue Apr 10, 2024 · 2 comments
Open
2 tasks done

Sketcher: indication that lines are overlapping #13381

FEA-eng opened this issue Apr 10, 2024 · 2 comments
Labels
Feature FR for improvements or new features UI/UX WB Sketcher Related to the Sketcher Workbench

Comments

@FEA-eng
Copy link
Contributor

FEA-eng commented Apr 10, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

Missing coincidences are probably the most common of sketching issues (discussed in #11799) but there's also another very common issue - overlapping lines. They are hard to spot when they overlap completely and only trying to delete such a line reveals that there's another line underneath it. Even the Validate Sketch tool is not very helpful here since it only highlights points. Overlapping lines may occur when a sketch is obtained from a draft, for instance, but also when sketching from the scratch and just trimming or playing with construction geometry.

Thus, I'd like to propose a way to warn the user about such situations. It could be a warning message, a different line color or even an option for the Validate Sketch tool to highlight and fix such lines (less helpful as it wouldn't warn the user automatically). Of course, I know that the lines may not overlap perfectly so maybe there should be some tolerance like with coincidences in Validate Sketch. But it seems that most cases are actually perfect overlaps.

@PaddleStroke FYI

Full version info

OS: Windows 10 build 19045
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.36784 (Git)
Build type: Release
Branch: main
Hash: d1930fc7e6fc35c413f9f39d22f2ea28fca827c7
Python 3.11.8, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: Polish/Poland (pl_PL)

Subproject(s) affected?

FEM

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz maxwxyz added the WB Sketcher Related to the Sketcher Workbench label Apr 10, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented Apr 10, 2024

I think this is implemented with the latest color PR, diyplaying coincident points in red? Also validate sketch tools allow the identification of such situations. Also, not all WB need closed wires or profiles. I guess mostly just Part Design.

@FEA-eng
Copy link
Contributor Author

FEA-eng commented Apr 10, 2024

I think this is implemented with the latest color PR, diyplaying coincident points in red?

Yes, but only for a disconnected line overlapped with another line. If you have a closed profile, all points are already red and there’s no way to see if there are any additional lines coincident with them.

Also validate sketch tools allow the identification of such situations.

The Validate Sketch tool can only highlight problematic vertices (suggesting regular missing coincidences) and can’t automatically fix such overlaps.

Also, not all WB need closed wires or profiles. I guess mostly just Part Design.

Yes, my concern is about PD workflows which are the most common ones. But overlapping lines, unlike missing coincidences, are pretty much never desired regardless of the workbench.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature FR for improvements or new features UI/UX WB Sketcher Related to the Sketcher Workbench
Projects
None yet
Development

No branches or pull requests

2 participants