Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measurement: Distance Factor and Mirror settings options need a tooltip #13805

Closed
2 tasks done
furgo16 opened this issue May 2, 2024 · 9 comments · Fixed by #13811
Closed
2 tasks done

Measurement: Distance Factor and Mirror settings options need a tooltip #13805

furgo16 opened this issue May 2, 2024 · 9 comments · Fixed by #13811
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Feature FR for improvements or new features UI/UX

Comments

@furgo16
Copy link
Contributor

furgo16 commented May 2, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

When going to Edit > Preferences > Measure > Appearance, the user can change the Measure tool settings. The function of at least two of them is not obvious, and would benefit from a tooltip (in addition to documentation):

  • Distance factor
  • Mirror

From a quick test, I've not noticed any difference in behavior when changing their setting, so I'm wondering if they are currently implemented.

image

Full version info

OS: Ubuntu Core 22 (ubuntu:GNOME/ubuntu)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37085 (Git) Snap 1005
Build type: Release
Branch: main
Hash: c7c07f28c639e82a6d2c58f4aaef5b42cddcc83c
Python 3.10.12, Qt 5.15.10, Coin 4.0.0, Vtk 7.1.1, OCC 7.7.1
Installed mods: 
  * OpenTheme 2024.4.20
  * BIM 2021.12.0
  * Curves 0.6.35
  * ezydxf
  * ExplodedAssembly
  * BillOfMaterials 0.0.8.2
  * Ondsel-Lens 2024.4.16.01
  * Assembly4 0.50.12

Subproject(s) affected?

Core

Anything else?

  1. In fact, all settings on that dialog need a tooltip, but the two mentioned in this issue might be the most pressing. The rest of the options there are more or less self-explanatory.
  2. As an aside, on the preferences page it would be logical to group the color-related settings: moving Background color to be after Line color might make more sense.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@maxwxyz maxwxyz added Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD UI/UX Feature FR for improvements or new features labels May 3, 2024
@maxwxyz
Copy link
Collaborator

maxwxyz commented May 3, 2024

@hlorus maybe you can help what they should do. I also did not find any changes when placing with these.

@hlorus
Copy link
Contributor

hlorus commented May 3, 2024

These are actually not needed at all, With UMF we have label dragging which makes the settings redundant. If i remember correctly the settings were ported over from Std_MeasureDistance where they would control the placement of the measurements.

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 3, 2024

should they be removed then or does this break stuff?

@furgo16
Copy link
Contributor Author

furgo16 commented May 3, 2024

With UMF we have label dragging which makes the settings redundant.

How does label dragging work, has it already landed? I don't seem to be able to drag any label.

@maxwxyz
Copy link
Collaborator

maxwxyz commented May 3, 2024

click and drag the label 😄
It seems not possible when it is over geometry.

@furgo16
Copy link
Contributor Author

furgo16 commented May 3, 2024

I had tried that with no success :-) My issue was that the distance between label and edge is reasonable for mm scale models, but it appears right on the edge for m scale models (Arch). That's why I started playing with the distance factor and trying to relocate the label. Again, unsuccessfully.

I'll see if I can upload a video. FWIW I'm using Gesture navigation, if that makes a difference.

@hlorus
Copy link
Contributor

hlorus commented May 3, 2024

They can be removed without breaking anything.

@furgo16
Copy link
Contributor Author

furgo16 commented May 3, 2024

Reported the related issue as #13808

@furgo16
Copy link
Contributor Author

furgo16 commented May 3, 2024

Indeed, their values seem to be defined, read, and then not used anywhere else:

double Preferences::defaultDistFactor()
{
return getPreferenceGroup("Appearance")->GetFloat("DefaultDistFactor", 1.0);
}

bool Preferences::defaultMirror()
{
return getPreferenceGroup("Appearance")->GetBool("DefaultMirror", false);
}

@furgo16 furgo16 changed the title Measure: Distance Factor and Mirror settings options need a tooltip Measurement: Distance Factor and Mirror settings options need a tooltip May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Feature FR for improvements or new features UI/UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants