Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sketcher] Internal alignment constraints should not be reported as redundant #6193

Closed
FreeCAD-Bug-Importer opened this issue Feb 7, 2022 · 6 comments
Assignees
Labels
Bug This issue or PR is related to a bug WB Sketcher Related to the Sketcher Workbench

Comments

@FreeCAD-Bug-Importer
Copy link
Collaborator

Issue imported from https://tracker.freecad.org/view.php?id=4619

  • Reporter: abdullah
  • Date submitted: 4/7/2021
  • FreeCAD version: 0.2
  • Category: Bug
  • Status: assigned
  • Tags:

Original report text

An internal alignment constraint can be redundant with other constraints, but it is never the one to be removed.
It may be possible to improve the algorithm suggesting redundant constraints, so that it does not suggest removing internal alignment constraints.

realthunder#97

Steps to reproduce

Unfortunately no file at this moment. If somebody comes along with one file, please upload it here.

FreeCAD Info

OS: Ubuntu 20.04.2 LTS (MATE/mate)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Branch: unknown
Hash: e8566f22bbeb0b7204e3c45519d0963e8881100b
Python version: 3.8.5
Qt version: 5.12.8
Coin version: 4.0.0
OCC version: 7.5.1

Other bug information

  • Priority: normal
  • Severity: minor
  • Category: Bug
  • Updated: 4/7/2021
@FreeCAD-Bug-Importer FreeCAD-Bug-Importer added WB Sketcher Related to the Sketcher Workbench Bug This issue or PR is related to a bug labels Feb 7, 2022
@luzpaz luzpaz changed the title Internal alignment constraints should not be reported as redundant [Sketcher] Internal alignment constraints should not be reported as redundant Feb 15, 2022
@AjinkyaDahale
Copy link
Contributor

AjinkyaDahale commented Apr 14, 2023

I believe this was fixed recently (around November 2022).

@luzpaz
Copy link
Contributor

luzpaz commented Apr 14, 2023

@AjinkyaDahale by whom and would you happen to pinpoint the commit(s)?

@AjinkyaDahale
Copy link
Contributor

@luzpaz aa67808. There may be more.

@luzpaz
Copy link
Contributor

luzpaz commented Apr 14, 2023

Closing per AjinkyaDahale

@luzpaz luzpaz closed this as completed Apr 14, 2023
@AjinkyaDahale
Copy link
Contributor

Noticed this was filed by @abdullahtahiriyo himself. Abdullah, please confirm this fixes the issue, and reopen if needed.

@abdullahtahiriyo
Copy link
Contributor

It should. I am ok with it closed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This issue or PR is related to a bug WB Sketcher Related to the Sketcher Workbench
Projects
None yet
Development

No branches or pull requests

4 participants