Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Regression: Hotkeys working incorrectly for view mode in sketcher #6206

Closed
FreeCAD-Bug-Importer opened this issue Feb 7, 2022 · 4 comments
Labels
Bug This issue or PR is related to a bug Regression Bugs describing a regression or PRs fixing one Shortcut UI/UX WB Sketcher Related to the Sketcher Workbench

Comments

@FreeCAD-Bug-Importer
Copy link
Collaborator

FreeCAD-Bug-Importer commented Feb 7, 2022

Issue imported from https://tracker.freecad.org/view.php?id=4644

  • Reporter: run_the_race
  • Date submitted: 4/25/2021
  • FreeCAD version: 0.19
  • Category: Bug
  • Status: new
  • Tags:

Original report text

In sketcher, display/render mode hotkeys dont work.

Additional information

Forum discussion: link

Steps to reproduce

In Sketcher press v, 3 to switch to shader mode wireframe, then v, 1 to switch back to normal. It won't switch shader modes, instead it switches perspective.

FreeCAD Info

OS: Windows 10 Version 2004
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24276 (Git)
Build type: Release
Branch: releases/FreeCAD-0-19
Hash: a88db11e0a908f6e38f92bfc5187b13ebe470438
Python version: 3.8.6+
Qt version: 5.15.1
Coin version: 4.0.1
OCC version: 7.5.0
Locale: English/United Kingdom (en_GB)

Other bug information

  • Priority: normal
  • Severity: minor
  • Category: Bug
  • OS: Windows 10 2004
  • Platform: PC
  • Updated: 12/29/2021

Discussion from Mantis ticket

Comment by @chennes 2021-12-29 03:33

@abdullahtahiriyo where does this bug (and #5872) stand now that you've reworked the Sketcher shortcuts?

@FreeCAD-Bug-Importer FreeCAD-Bug-Importer added WB Sketcher Related to the Sketcher Workbench Bug This issue or PR is related to a bug labels Feb 7, 2022
@luzpaz
Copy link
Contributor

luzpaz commented Jun 6, 2022

@abdullahtahiriyo if you don't mind taking a look at this?

@abdullahtahiriyo
Copy link
Contributor

@luzpaz
As I see, it still happens exactly what the bug report indicates.
The issue is that "V" is the shortcut of "Vertical constraint". In the current configuration it is not possible to tackle it.

Now, there is a PR by RealThunder which I really really would like to see it merged, which would enable to differentiate between V and V,1. He uses a timer, so if the two are clicked within a time duration, then "V,1" is taken (and it should work just fine to do what the OP wants). If it times out then it is just "V" and then "1", which is what is happening now.

So when the feature freeze is removed, we could try to merge that one...

@luzpaz luzpaz added Regression Bugs describing a regression or PRs fixing one and removed File format: AMF labels Nov 15, 2023
@luzpaz
Copy link
Contributor

luzpaz commented Nov 15, 2023

@PaddleStroke here's another Sketcher shortcut related ticket that could get attention (since #11402 was tackled). Although it may not be as straight-forward.

@luzpaz luzpaz changed the title Hotkeys working incorrectly for view mode in sketcher [Problem] Regression: Hotkeys working incorrectly for view mode in sketcher Nov 15, 2023
@abdullahtahiriyo
Copy link
Contributor

@luzpaz

This issue is fixed. My guess is that RT's PR was merged. Now "V" (Vertical constraint) lives happily with "V,1" and "V,3".

It may not be straight-forward to see it, but: Create one sketch on one plane (e.g., XY). Draw one line. Close. Create a second sketch on the same plane. Ensure the previous sketch is visible. You will see the line of the other sketch. Click "V", the "3" reasonably fast one after the other. The shade mode changes.

So the hotkey issue is solved.

@luzpaz luzpaz closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This issue or PR is related to a bug Regression Bugs describing a regression or PRs fixing one Shortcut UI/UX WB Sketcher Related to the Sketcher Workbench
Projects
None yet
Development

No branches or pull requests

3 participants