App: Do not use stuff from Part module here (PyObject *PropertyContainerPy::getCustomAttributes)

[luzpaz]

FreeCAD/src/App/PropertyContainerPyImp.cpp

Lines 569 to 599 in eebdaad

	///FIXME: For v0.20: Do not use stuff from Part module here!
	else if(Base::streq(attr,"Shape") && getPropertyContainerPtr()->isDerivedFrom(App::DocumentObject::getClassTypeId())) {
	// Special treatment of Shape property
	static PyObject *_getShape = nullptr;
	if(!_getShape) {
	_getShape = Py_None;
	PyObject *mod = PyImport_ImportModule("Part");
	if(!mod) {
	PyErr_Clear();
	} else {
	Py::Object pyMod = Py::asObject(mod);
	if(pyMod.hasAttr("getShape"))
	_getShape = Py::new_reference_to(pyMod.getAttr("getShape"));
	}
	}
	if(_getShape != Py_None) {
	Py::Tuple args(1);
	args.setItem(0,Py::Object(const_cast<PropertyContainerPy*>(this)));
	auto res = PyObject_CallObject(_getShape, args.ptr());
	if(!res)
	PyErr_Clear();
	else {
	Py::Object pyres(res,true);
	if(pyres.hasAttr("isNull")) {
	Py::Callable func(pyres.getAttr("isNull"));
	if(!func.apply().isTrue())
	return Py::new_reference_to(res);
	}
	}
	}
	}

[donovaly]

Why is this for 0.20? Is there a regression or potential memory leak?

[donovaly]

@wwmayer could you have a quick look if you agree we must do something for 0.20 here?

[wwmayer]

It's fine to postpone to v0.21. It's not urgent but at some point it must be fixed.

[donovaly]

Thanks.

[luzpaz]

Why is this for 0.20? Is there a regression or potential memory leak?

Just for completion: the comment on line 569 says so: ///FIXME: For v0.20: Do not use stuff from Part module here! hence the original title of the ticket.